Skip to content

TEZ-4456: Upgraded is-my-json-valid version to 2.20.3 to fix the vulnerability - #250

Merged
abstractdog merged 1 commit into
apache:masterfrom
amanraj2520:TEZ-4456_is-my-valid-json-upgrade
Nov 28, 2022
Merged

TEZ-4456: Upgraded is-my-json-valid version to 2.20.3 to fix the vulnerability#250
abstractdog merged 1 commit into
apache:masterfrom
amanraj2520:TEZ-4456_is-my-valid-json-upgrade

Conversation

@amanraj2520

@amanraj2520amanraj2520 commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

TEZ-4456: Upgraded is-my-json-valid version to 2.20.3 to fix the vulnerability. This is a critical vulnerability to fix. The parent JIRA can be tracked under : https://issues.apache.org/jira/browse/TEZ-4419

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
2m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-250/1/artifact/out/Dockerfile
GITHUB PR#250
JIRA IssueTEZ-4456
Optional Testsdupname asflicense
unameLinux 82d43bb24976 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 65f9ee3
Max. process+thread count46 (vs. ulimit of 5500)
modulesC: tez-ui U: tez-ui
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-250/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@amanraj2520

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Can you please check and approve this PR

is-my-json-valid@^2.12.4:
version "2.16.0"
resolved "https://registry.yarnpkg.com/is-my-json-valid/-/is-my-json-valid-2.16.0.tgz#f079dd9bfdae65ee2038aae8acbc86ab109e3693"
is-my-ip-valid@^1.0.0:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are the is-my-ip-valid changes related to is-my-json-valid upgrade?

@amanraj2520

Copy link
Copy Markdown
ContributorAuthor

Hi @abstractdog these dependencies come up as you build the 2.20.3 version. They are required to build the is-valid-json 2.20.3. I have not made manual changes to this file. They are autogenerated from the package.json

@abstractdog
abstractdog self-requested a review November 28, 2022 11:15
@abstractdog

Copy link
Copy Markdown
Contributor

thanks for clarifying @amanraj2520 , +1

@abstractdog
abstractdog merged commit 25fc8c4 into apache:masterNov 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amanraj2520@tez-yetus@abstractdog