Skip to content

TEZ-4461: Upgrade spring-core to 5.3.20 in wro4j-maven-plugin - #255

Open
dmmkr wants to merge 1 commit into
apache:masterfrom
dmmkr:TEZ-4461
Open

TEZ-4461: Upgrade spring-core to 5.3.20 in wro4j-maven-plugin#255
dmmkr wants to merge 1 commit into
apache:masterfrom
dmmkr:TEZ-4461

Conversation

@dmmkr

@dmmkrdmmkr commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec32m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 9smaster passed
+1 💚compile0m 47smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚compile0m 47smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javadoc0m 43smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 23smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Patch Compile Tests _
+1 💚mvninstall1m 14sthe patch passed
+1 💚compile0m 45sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javac0m 45sthe patch passed
+1 💚compile0m 45sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javac0m 45sthe patch passed
-1 ❌whitespace0m 0sThe patch 2 line(s) with tabs.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 21sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 22sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Other Tests _
+1 💚unit1m 37stez-ui in the patch passed.
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
56m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/1/artifact/out/Dockerfile
GITHUB PR#255
JIRA IssueTEZ-4461
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux d4893c6191bf 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 34d6810
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
whitespacehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/1/artifact/out/whitespace-tabs.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/1/testReport/
Max. process+thread count94 (vs. ulimit of 5500)
modulesC: tez-ui U: tez-ui
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 27smaster passed
+1 💚compile0m 47smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚compile0m 46smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javadoc0m 44smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 23smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Patch Compile Tests _
+1 💚mvninstall1m 16sthe patch passed
+1 💚compile0m 43sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javac0m 43sthe patch passed
+1 💚compile0m 46sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javac0m 46sthe patch passed
-1 ❌whitespace0m 0sThe patch 2 line(s) with tabs.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 24sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 22sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Other Tests _
+1 💚unit1m 39stez-ui in the patch passed.
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
25m 25s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/2/artifact/out/Dockerfile
GITHUB PR#255
JIRA IssueTEZ-4461
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 6990699cbd75 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 34d6810
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
whitespacehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/2/artifact/out/whitespace-tabs.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/2/testReport/
Max. process+thread count95 (vs. ulimit of 5500)
modulesC: tez-ui U: tez-ui
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-255/2/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comment threadtez-ui/pom.xml
<plugin>
<groupId>ro.isdc.wro4j</groupId>
<artifactId>wro4j-maven-plugin</artifactId>
<dependencies>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of bumping the version, wouldn't it make sense to simply exclude these problematic dependencies?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dmmkr@tez-yetus@abstractdog