Skip to content

TEZ-4394: Netty4 ShuffleHandler: should use 1 boss thread - #256

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4394
Feb 28, 2023
Merged

TEZ-4394: Netty4 ShuffleHandler: should use 1 boss thread#256
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4394

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec31m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 47smaster passed
+1 💚compile0m 31smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚compile0m 29smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚checkstyle1m 6smaster passed
+1 💚javadoc0m 36smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 26smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗spotbugs1m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 3smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 25sthe patch passed
+1 💚compile0m 16sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javac0m 16sthe patch passed
+1 💚compile0m 15sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javac0m 15sthe patch passed
+1 💚checkstyle0m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 12sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 11sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚findbugs0m 34sthe patch passed
_ Other Tests _
+1 💚unit2m 46stez-aux-services in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
57m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-256/1/artifact/out/Dockerfile
GITHUB PR#256
JIRA IssueTEZ-4394
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux acf61d876684 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 34d6810
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-256/1/testReport/
Max. process+thread count1472 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-256/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@rbalamohanrbalamohan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
abstractdog merged commit 051e90f into apache:masterFeb 28, 2023
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 11, 2024
… (Laszlo Bodor reviewed by Rajesh Balamohan)
(cherry picked from commit 051e90f)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 20, 2024
… (Laszlo Bodor reviewed by Rajesh Balamohan)
(cherry picked from commit 051e90f)
(cherry picked from commit f9cbbf4)
prabhjyotsingh added a commit to acceldata-io/tez that referenced this pull request Nov 20, 2024
…pache#256) (Laszlo Bodor reviewed by Rajesh Balamohan) (#18)
(cherry picked from commit 051e90f)
(cherry picked from commit f9cbbf4)
Co-authored-by: Bodor Laszlo <bodorlaszlo0202@gmail.com>
shubhluck pushed a commit to acceldata-io/tez that referenced this pull request Nov 21, 2024
…pache#256) (Laszlo Bodor reviewed by Rajesh Balamohan) (#18)
(cherry picked from commit 051e90f)
(cherry picked from commit f9cbbf4)
Co-authored-by: Bodor Laszlo <bodorlaszlo0202@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@rbalamohan