Skip to content

TEZ-4464: Update some links to https - #260

Merged
abstractdog merged 1 commit into
apache:masterfrom
raboof:https-links
Jan 2, 2023
Merged

TEZ-4464: Update some links to https#260
abstractdog merged 1 commit into
apache:masterfrom
raboof:https-links

Conversation

@raboof

Copy link
Copy Markdown
Member

No description provided.

@tez-yetus

This comment was marked as outdated.

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for this contribution @raboof , can you please create jira also?
https://issues.apache.org/jira/projects/TEZ/

@raboof
raboofforce-pushed the https-links branch 2 times, most recently from 13ac301 to 9b20e8aCompareDecember 23, 2022 12:45
@raboofraboof changed the title Update some links to https[TEZ-4464] Update some links to httpsDec 23, 2022
@raboofraboof changed the title [TEZ-4464] Update some links to httpsTEZ-4464: Update some links to httpsDec 23, 2022
@raboof

Copy link
Copy Markdown
MemberAuthor

Please justify why no new tests are needed for this patch.

no tests were added because adding a link checker to the CI seems beyond the scope of this PR.

Also please list what manual steps were performed to verify this patch.

I manually followed most updated links to verify the linked sites indeed support https. I did not verify the pages still serve useful content.

can you please create jira also?

Sure, done!

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec39m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall18m 9smaster passed
+1 💚compile0m 20smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚compile0m 17smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚mvnsite0m 21smaster passed
+1 💚javadoc0m 39smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 19smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Patch Compile Tests _
+1 💚mvninstall0m 8sthe patch passed
+1 💚compile0m 8sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javac0m 8sthe patch passed
+1 💚compile0m 7sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javac0m 7sthe patch passed
-1 ❌markdownlint0m 7sThe patch generated 2 new + 195 unchanged - 2 fixed = 197 total (was 197)
+1 💚mvnsite0m 7sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc0m 8sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc0m 8sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Other Tests _
+1 💚unit0m 8sdocs in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
61m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/artifact/out/Dockerfile
GITHUB PR#260
JIRA IssueTEZ-4464
Optional Testsdupname asflicense javac javadoc unit xml compile markdownlint mvnsite
unameLinux 427d1328a191 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 34d6810
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
markdownlinthttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/artifact/out/diff-patch-markdownlint.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/testReport/
Max. process+thread count72 (vs. ulimit of 5500)
modulesC: docs U: docs
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/console
versionsgit=2.25.1 maven=3.6.3 markdownlint=0.23.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review January 2, 2023 08:47

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdownlint issues are not introduced by this patch, LGTM +1

@abstractdog
abstractdog merged commit 4fd2db3 into apache:masterJan 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@raboof@tez-yetus@abstractdog