Skip to content

TEZ-4470: typo fixes - #264

Merged
abstractdog merged 10 commits into
apache:masterfrom
mlorek:typos1
Jun 12, 2023
Merged

TEZ-4470: typo fixes#264
abstractdog merged 10 commits into
apache:masterfrom
mlorek:typos1

Conversation

@mlorek

@mlorekmlorek commented Feb 4, 2023

Copy link
Copy Markdown
Contributor

minor fixes in var,method names and comments

@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog

abstractdog commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

not sure what's happening in the precommit, need to check this week:
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/1/console

@mlorek

mlorek commented Feb 7, 2023

Copy link
Copy Markdown
ContributorAuthor

not sure what's happening in the precommit, need to check this week: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/1/console

not sure what's happening in the precommit, need to check this week: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/1/console

anything i can do to help?

@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog
abstractdog self-requested a review February 15, 2023 07:51
abstractdog
abstractdog reviewed Feb 15, 2023
View reviewed changes
Comment threadtez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/ScatterGatherEdgeManager.java
int physicalOutputs = getContext().getDestinationVertexNumTasks();
Preconditions.checkArgument(physicalOutputs >= 0,
"ScatteGather edge manager must have destination vertex task parallelism specified");
"ScatterGather edge manager must have destination vertex task parallelism specified");

@abstractdogabstractdogFeb 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the asserted message in TestEdge.testScatterGatherManager as well

@abstractdog

abstractdog commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

thanks @mlorek for taking care of this
could you please check how the mvnsite failures are related to the patch (if they're related)?

@tez-yetus

This comment was marked as outdated.

Sign in to view
@mlorek

mlorek commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

mvnsite errors are related to:

Loading source files for package org.apache.tez.examples...
Constructing Javadoc information...
IncludePublicAnnotationsStandardDoclet
...
[ERROR] Exit code: 1 - javadoc: error - No public or protected classes found to document.

@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus

This comment was marked as outdated.

Sign in to view
@mlorek

mlorek commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@abstractdog all good?

@tez-yetus

This comment was marked as outdated.

Sign in to view
@mlorek
Merge branch 'master' into typos1
2251e0e
# Conflicts:
#	tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java
@tez-yetus

This comment was marked as outdated.

Sign in to view
@mlorek

mlorek commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

@abstractdog can you take another look?

@abstractdog

abstractdog commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

@mlorek : have you had the chance to check the root cause of test failures in some modules?

@mlorek

mlorek commented Mar 28, 2023

Copy link
Copy Markdown
ContributorAuthor

@abstractdog I see only 1 failed test and it's not related to my changes:

Error Message
port out of range:-1
Stacktrace
java.lang.IllegalArgumentException: port out of range:-1
at org.apache.tez.test.TestAMRecovery.runDAGAndVerify(TestAMRecovery.java:416)
at org.apache.tez.test.TestAMRecovery.testVertexCompletelyFinished_Broadcast(TestAMRecovery.java:242)

@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus

tez-yetus commented May 16, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec25m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep6m 9sMaven dependency ordering for branch
+1 💚mvninstall10m 17smaster passed
+1 💚compile6m 30smaster passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚compile6m 16smaster passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+1 💚checkstyle5m 35smaster passed
-1 ❌mvnsite0m 31stez-examples in master failed.
-1 ❌mvnsite0m 41stez-dag in master failed.
-1 ❌mvnsite0m 34stez-tests in master failed.
-1 ❌mvnsite0m 31stez-aux-services in master failed.
-1 ❌mvnsite0m 35sjob-analyzer in master failed.
+1 💚javadoc5m 36smaster passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚javadoc5m 22smaster passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+0 🆗spotbugs0m 44sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 47sbranch/tez-ui no findbugs output file (findbugsXml.xml)
+0 🆗findbugs0m 23sbranch/docs no findbugs output file (findbugsXml.xml)
-0 ⚠️patch2m 0sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall5m 49sthe patch passed
+1 💚jshint53m 18sThere were no new jshint issues.
+1 💚compile6m 24sthe patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚javac6m 24sthe patch passed
+1 💚compile6m 1sthe patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+1 💚javac6m 1sthe patch passed
+1 💚checkstyle0m 29stez-api: The patch generated 0 new + 198 unchanged - 1 fixed = 198 total (was 199)
+1 💚checkstyle0m 23sThe patch passed checkstyle in tez-common
+1 💚checkstyle0m 24sThe patch passed checkstyle in tez-runtime-internals
-0 ⚠️checkstyle0m 36stez-runtime-library: The patch generated 6 new + 373 unchanged - 13 fixed = 379 total (was 386)
+1 💚checkstyle0m 21sThe patch passed checkstyle in tez-examples
-0 ⚠️checkstyle0m 45stez-dag: The patch generated 5 new + 509 unchanged - 5 fixed = 514 total (was 514)
+1 💚checkstyle0m 24sThe patch passed checkstyle in tez-tests
+1 💚checkstyle0m 19sThe patch passed checkstyle in tez-ui
+1 💚checkstyle0m 23sThe patch passed checkstyle in tez-history-parser
+1 💚checkstyle0m 23sThe patch passed checkstyle in tez-aux-services
-0 ⚠️checkstyle0m 22stez-tools/analyzers/job-analyzer: The patch generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14)
+1 💚checkstyle0m 19sThe patch passed checkstyle in docs
+1 💚markdownlint0m 2sThere were no new markdownlint issues.
-1 ❌mvnsite0m 30stez-examples in the patch failed.
-1 ❌mvnsite0m 38stez-dag in the patch failed.
-1 ❌mvnsite0m 34stez-tests in the patch failed.
-1 ❌mvnsite0m 32stez-aux-services in the patch failed.
-1 ❌mvnsite0m 33sjob-analyzer in the patch failed.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc5m 29sthe patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚javadoc5m 18sthe patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+0 🆗findbugs0m 45stez-ui has no data from findbugs
+0 🆗findbugs0m 23sdocs has no data from findbugs
_ Other Tests _
+1 💚unit2m 26stez-api in the patch passed.
+1 💚unit0m 38stez-common in the patch passed.
+1 💚unit0m 51stez-runtime-internals in the patch passed.
+1 💚unit5m 54stez-runtime-library in the patch passed.
+1 💚unit0m 27stez-examples in the patch passed.
+1 💚unit5m 21stez-dag in the patch passed.
+1 💚unit44m 15stez-tests in the patch passed.
+1 💚unit1m 40stez-ui in the patch passed.
+1 💚unit2m 41stez-history-parser in the patch passed.
+1 💚unit3m 5stez-aux-services in the patch passed.
+1 💚unit3m 0sjob-analyzer in the patch passed.
+1 💚unit0m 24sdocs in the patch passed.
+1 💚asflicense4m 44sThe patch does not generate ASF License warnings.
278m 48s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/Dockerfile
GITHUB PR#264
JIRA IssueTEZ-4470
Optional Testsdupname asflicense markdownlint mvnsite javac javadoc unit spotbugs findbugs checkstyle compile jshint
unameLinux c4bd388351c5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / ccad71d
Default JavaPrivate Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/branch-mvnsite-tez-examples.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/branch-mvnsite-tez-dag.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/branch-mvnsite-tez-tests.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/branch-mvnsite-tez-plugins_tez-aux-services.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/branch-mvnsite-tez-tools_analyzers_job-analyzer.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/diff-checkstyle-tez-runtime-library.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/diff-checkstyle-tez-dag.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/patch-mvnsite-tez-examples.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/patch-mvnsite-tez-dag.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/patch-mvnsite-tez-tests.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/patch-mvnsite-tez-plugins_tez-aux-services.txt
mvnsitehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/artifact/out/patch-mvnsite-tez-tools_analyzers_job-analyzer.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-examples tez-dag tez-tests tez-ui tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer docs U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-264/10/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1 jshint=2.12.0 markdownlint=0.23.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented Jun 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

this patch waits for a long time, let me check the mvn site problems in the scope of TEZ-4495
I don't think they are related as I was able to reproduce it on master too, so I'm about to approve this PR if every failure is unrelated and tracked
UPDATE: confirmed, none of the checkstyle problems was caused by this patch, they were already present

@abstractdog
abstractdog merged commit 987ec54 into apache:masterJun 12, 2023
abstractdog
abstractdog reviewed Jun 12, 2023
View reviewed changes

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractdogabstractdogabstractdog left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlorek@tez-yetus@abstractdog