Skip to content

TEZ-4471: Precommit fails while building yetus image - #265

Merged
abstractdog merged 3 commits into
apache:masterfrom
abstractdog:TEZ-4471
Feb 13, 2023
Merged

TEZ-4471: Precommit fails while building yetus image#265
abstractdog merged 3 commits into
apache:masterfrom
abstractdog:TEZ-4471

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/1/console in case of problems.

@abstractdog

abstractdog commented Feb 10, 2023

Copy link
Copy Markdown
ContributorAuthor

I haven't been able to reproduce the issue locally, so simply upgraded to the next LTS ubuntu version, seems to work

I'm keeping this open for a couple of hours for reviews, then merge it anyway to unblock precommit

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/2/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/3/console in case of problems.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Anyway good to upgrade to the latest LTS release

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/4/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/5/console in case of problems.

@abstractdog

abstractdog commented Feb 12, 2023

Copy link
Copy Markdown
ContributorAuthor

after some hacking I realized the root cause of installation failures in tez-ui is the absence of the bzip2 package, handling it with the latest commit
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~22.04-b08.txt

[INFO] tar (child): bzip2: Cannot exec: No such file or directory

@ayushtkn

Copy link
Copy Markdown
Member

So, is there any commit which added the dependency on bzip2? Just curious then why didn't it fail in that PR jenkins report

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

it's because tez precommit flow depends on which files have been modified, e.g. when you only change the Dockerfile, there is no full precommit run, only the docker image is built
that's why I added a fake commit to change pom.xml to run full precommit:
e87a0de

actually, the bzip2 change is here:
b0fce54

once the precommit passes, I'll simply remove the pom.xml hack

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/6/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/7/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 50sMaven dependency ordering for branch
+1 💚mvninstall10m 43smaster passed
+1 💚compile2m 57smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚compile2m 46smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javadoc2m 38smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc2m 6smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 39sthe patch passed
+1 💚compile2m 59sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javac2m 59sthe patch passed
+1 💚compile2m 45sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javac2m 45sthe patch passed
+1 💚hadolint0m 2sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc2m 26sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc2m 8sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Other Tests _
+1 💚unit1m 35stez-ui in the patch passed.
+1 💚unit70m 6sroot in the patch passed.
+1 💚asflicense1m 6sThe patch does not generate ASF License warnings.
138m 58s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/6/artifact/out/Dockerfile
GITHUB PR#265
JIRA IssueTEZ-4471
Optional Testsdupname asflicense hadolint shellcheck shelldocs javac javadoc unit xml compile
unameLinux a3ccd766fff2 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 39e5a8e
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/6/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/6/console
versionsgit=2.34.1 maven=3.6.3 shellcheck=0.7.1 hadolint=1.18.0-0-g76eee5c
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 57sMaven dependency ordering for branch
+1 💚mvninstall10m 41smaster passed
+1 💚compile2m 57smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚compile2m 48smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javadoc2m 39smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc2m 7smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 38sthe patch passed
+1 💚compile2m 55sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javac2m 55sthe patch passed
+1 💚compile2m 48sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javac2m 48sthe patch passed
+1 💚hadolint0m 3sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc2m 27sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc2m 5sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Other Tests _
+1 💚unit1m 37stez-ui in the patch passed.
+1 💚unit75m 16sroot in the patch passed.
+1 💚asflicense1m 5sThe patch does not generate ASF License warnings.
122m 1s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/7/artifact/out/Dockerfile
GITHUB PR#265
JIRA IssueTEZ-4471
Optional Testsdupname asflicense hadolint shellcheck shelldocs javac javadoc unit xml compile
unameLinux 3eb61d42993a 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 39e5a8e
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/7/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-265/7/console
versionsgit=2.34.1 maven=3.6.3 shellcheck=0.7.1 hadolint=1.18.0-0-g76eee5c
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

okay, latest precommit passed, I'm about to proceed with it tomorrow

@rbalamohan

Copy link
Copy Markdown
Contributor

LGTM +1

@abstractdog
abstractdog merged commit e236f51 into apache:masterFeb 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@tez-yetus@ayushtkn@rbalamohan