Skip to content

TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test - #267

Merged
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4475
Feb 14, 2023
Merged

TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test#267
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4475

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@abstractdogabstractdog changed the title TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too quickly - causing NPE in unit testTEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit testFeb 13, 2023
@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec23m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall15m 37smaster passed
+1 💚compile0m 32smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚compile0m 31smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚checkstyle1m 5smaster passed
+1 💚javadoc0m 36smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc0m 26smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+0 🆗spotbugs1m 10sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 18sthe patch passed
+1 💚compile0m 19sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javac0m 19sthe patch passed
+1 💚compile0m 17sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javac0m 17sthe patch passed
-0 ⚠️checkstyle0m 11stez-tests: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 13sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc0m 12sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚findbugs0m 37sthe patch passed
_ Other Tests _
+1 💚unit39m 41stez-tests in the patch passed.
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
86m 24s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/artifact/out/Dockerfile
GITHUB PR#267
JIRA IssueTEZ-4475
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 8c6d3d8aaf08 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / e3e91a1
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/artifact/out/diff-checkstyle-tez-tests.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/testReport/
Max. process+thread count1331 (vs. ulimit of 5500)
modulesC: tez-tests U: tez-tests
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@rbalamohanrbalamohan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
abstractdog merged commit 97cc788 into apache:masterFeb 14, 2023
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 4s#267 does not apply to master. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez for help.
SubsystemReport/Notes
GITHUB PR#267
JIRA IssueTEZ-4475
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/3/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@rbalamohan