Skip to content

TEZ-4467: Migrate from Travis CI to GitHub Actions - pt2: remove .travis.yml - #269

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4467
Jun 12, 2023
Merged

TEZ-4467: Migrate from Travis CI to GitHub Actions - pt2: remove .travis.yml#269
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4467

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdogabstractdog changed the title TEZ-4467: Migrate from Travis CI to GitHub ActionsTEZ-4467: Migrate from Travis CI to GitHub Actions - pt2: remove .travis.ymlFeb 15, 2023
@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚yamllint0m 1sThe patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
_ Other Tests _
+1 💚asflicense1m 1sThe patch does not generate ASF License warnings.
2m 21s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/5/artifact/out/Dockerfile
GITHUB PR#269
JIRA IssueTEZ-4467
Optional Testsdupname asflicense yamllint
unameLinux ff2ae3c9b0e7 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / be99489
Max. process+thread count46 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/5/console
versionsgit=2.34.1 maven=3.6.3 yamllint=1.24.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 39smaster passed
+1 💚compile2m 16smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚compile2m 8smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javadoc2m 36smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc1m 50smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Patch Compile Tests _
+1 💚mvninstall3m 59sthe patch passed
+1 💚compile2m 12sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javac2m 12sthe patch passed
+1 💚compile1m 58sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚javac1m 58sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚yamllint0m 0sThe patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚javadoc2m 3sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚javadoc1m 45sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Other Tests _
+1 💚unit73m 22sroot in the patch passed.
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
112m 14s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/artifact/out/Dockerfile
GITHUB PR#269
JIRA IssueTEZ-4467
Optional Testsdupname asflicense javac javadoc unit xml compile yamllint
unameLinux 2151293f45d3 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / be99489
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/testReport/
Max. process+thread count1923 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/console
versionsgit=2.34.1 maven=3.6.3 yamllint=1.24.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

can you please approve this one @rbalamohan, @jteagles?
here is the history:

  1. I needed to merge another PR to see GitHub actions in action :) that's why it successfully kicked off 4 different Build CI steps here (TEZ-4467: Migrate from Travis CI to GitHub Actions - initial commit started from GitHub UI #270)
  2. this PR is about to remove .travis.yml
  3. also confirmed that the background precommit test runs (see results above)

travis is EOL from Feb15, so please review and let me merge this one

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

please someone review, this is already working on master, we should cleanup the old travis.yml

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Travis CI is gone, good to cleanup

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

LGTM Travis CI is gone, good to cleanup

thanks @ayushtkn for the review!
I'm about to merge this even with the absence of a tez committer review, this is an obvious cleanup task

@ayushtkn

Copy link
Copy Markdown
Member

hmm, no say in project maters but worth exploring CTR for Tez
https://www.apache.org/foundation/glossary.html#CommitThenReview

@ayushtkn

Copy link
Copy Markdown
Member

@abstractdog
abstractdog merged commit 6722ef3 into apache:masterJun 12, 2023
@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks @ayushtkn for taking a look
CTR is definitely the way to go in case of Tez considering the current state of the community, let me think about that

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn