Uh oh!
There was an error while loading. Please reload this page.
TEZ-4487: Add class name profiling option in ProfileServlet - #281
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
left a comment
There was a problem hiding this comment.
minor formatting issue, other than that LGTM
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
difin
commented
Apr 13, 2023
Hi @abstractdog , I fixed the line that had a whitespace, but it says there is one more line that ends with a whitespace. I checked all the lines that I changed and couldn't find additional whitespace. |
@difin: there is indeed a whitespace in line 208, checked locally |
aturoczy
commented
Apr 16, 2023
Sharp eyes :) |
difin
commented
Apr 17, 2023
Hi @abstractdog, |
tez-yetus
commented
Apr 17, 2023
💔 -1 overall
This message was automatically generated. |
What changes were proposed in this pull request?
Adding support for method name profiling to Tez's ProfileServlet.
Why are the changes needed?
Tez has ProfileServlet. It makes use of async-profiler and allows profiling specific events. Currently profileServlet supports events like cpu, alloc, lock etc. It will be good to enhance to support method name profiling as well.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Automated pre-commit tests;
Manual testing was done as part of HIVE-27184 and the same changes are proposed here.