Skip to content

TEZ-4495: mvnsite fails for some modules - No public or protected classes found to document - #288

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4495
Jun 19, 2023
Merged

TEZ-4495: mvnsite fails for some modules - No public or protected classes found to document#288
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4495

Conversation

@abstractdog

@abstractdogabstractdog commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

As described in jira, mvn site command fails for some modules. Instead of taking care of javadoc compliance of some non-production modules, it would make sense disable the plugin for all of the modules for which javadocs are not published,

@tez-yetus

This comment was marked as outdated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference this is mentioned on this ticket: MJAVADOC-274

I tried this locally, was able to repro & post fix it works for me.

Changes LGTM

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep7m 26sMaven dependency ordering for branch
+1 💚mvninstall11m 9smaster passed
+1 💚compile4m 25smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚compile4m 2smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javadoc4m 19smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc3m 41smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 29sthe patch passed
+1 💚compile4m 18sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javac4m 18sthe patch passed
+1 💚compile4m 4sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javac4m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 5sThe patch has no ill-formed XML file.
+1 💚javadoc0m 43stez-api in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚javadoc0m 36stez-runtime-library in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚javadoc0m 34stez-mapreduce in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚javadoc1m 17sroot-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 generated 0 new + 29 unchanged - 52 fixed = 29 total (was 81)
+1 💚javadoc2m 58sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚unit2m 34stez-api in the patch passed.
+1 💚unit6m 9stez-runtime-library in the patch passed.
+1 💚unit1m 40stez-mapreduce in the patch passed.
+1 💚unit74m 27sroot in the patch passed.
+1 💚asflicense2m 3sThe patch does not generate ASF License warnings.
166m 14s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/artifact/out/Dockerfile
GITHUB PR#288
JIRA IssueTEZ-4495
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux affa74050494 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 86b1199
Default JavaPrivate Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-mapreduce . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit a1a8f20 into apache:masterJun 19, 2023
@abstractdog

Copy link
Copy Markdown
ContributorAuthor

merged this as it blocked precommit mvnsite, thanks @ayushtkn for the review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn