Skip to content

TEZ-4478: Refactor dependency versions into properties in pom. - #291

Merged
abstractdog merged 1 commit into
apache:masterfrom
ayushtkn:TEZ-4478
Jun 20, 2023
Merged

TEZ-4478: Refactor dependency versions into properties in pom.#291
abstractdog merged 1 commit into
apache:masterfrom
ayushtkn:TEZ-4478

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec23m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 12sMaven dependency ordering for branch
+1 💚mvninstall11m 41smaster passed
+1 💚compile7m 49smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚compile7m 4smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javadoc8m 6smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc6m 46smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall8m 41sthe patch passed
+1 💚compile7m 47sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javac7m 47sthe patch passed
+1 💚compile7m 22sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javac7m 22sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 13sThe patch has no ill-formed XML file.
+1 💚javadoc7m 18sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc6m 45sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚unit2m 26stez-api in the patch passed.
+1 💚unit0m 54stez-runtime-internals in the patch passed.
+1 💚unit5m 59stez-runtime-library in the patch passed.
+1 💚unit1m 41stez-mapreduce in the patch passed.
+1 💚unit5m 27stez-dag in the patch passed.
+1 💚unit4m 22stez-ext-service-tests in the patch passed.
+1 💚unit0m 42stez-protobuf-history-plugin in the patch passed.
+1 💚unit3m 8stez-aux-services in the patch passed.
+1 💚unit0m 27sdocs in the patch passed.
+1 💚unit74m 26sroot in the patch passed.
+1 💚asflicense4m 55sThe patch does not generate ASF License warnings.
216m 47s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/artifact/out/Dockerfile
GITHUB PR#291
JIRA IssueTEZ-4478
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux ac19ad52943d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 86b1199
Default JavaPrivate Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-aux-services docs . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comment threadpom.xml Outdated
<distMgmtStagingName>Apache Release Distribution Repository</distMgmtStagingName>
<distMgmtStagingUrl>https://repository.apache.org/service/local/staging/deploy/maven2</distMgmtStagingUrl>

<!-- dependency versions in alphabetical order-->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent comment with properties

@abstractdog
abstractdog self-requested a review June 19, 2023 21:17

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, other than that +1

Change-Id: Iefa56a3defaad073f439ce30b980853c3a8ce54f
@abstractdog
abstractdog merged commit d20f334 into apache:masterJun 20, 2023
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 37sMaven dependency ordering for branch
+1 💚mvninstall11m 50smaster passed
+1 💚compile7m 49smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚compile7m 31smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javadoc5m 53smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc5m 16smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall7m 35sthe patch passed
+1 💚compile7m 52sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javac7m 52sthe patch passed
+1 💚compile7m 24sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javac7m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 13sThe patch has no ill-formed XML file.
+1 💚javadoc5m 25sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc5m 27sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚unit2m 31stez-api in the patch passed.
+1 💚unit0m 54stez-runtime-internals in the patch passed.
+1 💚unit6m 4stez-runtime-library in the patch passed.
+1 💚unit1m 39stez-mapreduce in the patch passed.
+1 💚unit5m 26stez-dag in the patch passed.
+1 💚unit4m 31stez-ext-service-tests in the patch passed.
+1 💚unit0m 40stez-protobuf-history-plugin in the patch passed.
+1 💚unit3m 6stez-aux-services in the patch passed.
+1 💚unit0m 25sdocs in the patch passed.
+1 💚unit74m 58sroot in the patch passed.
+1 💚asflicense5m 2sThe patch does not generate ASF License warnings.
187m 20s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/artifact/out/Dockerfile
GITHUB PR#291
JIRA IssueTEZ-4478
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux c08df1688944 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / a1a8f20
Default JavaPrivate Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-aux-services docs . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog