Skip to content

TEZ-4473: Remove pointless MDC_LOGGING message from logs if there is no custom MDC key. - #294

Merged
abstractdog merged 2 commits into
apache:masterfrom
ayushtkn:TEZ-4473
Jun 23, 2023
Merged

TEZ-4473: Remove pointless MDC_LOGGING message from logs if there is no custom MDC key.#294
abstractdog merged 2 commits into
apache:masterfrom
ayushtkn:TEZ-4473

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

No description provided.

…no custom MDC key.
Change-Id: I8baf4e8500c4ca126a40ee7ea328821f3da8fb45
@tez-yetus

This comment was marked as outdated.

Change-Id: I867ef0de996a5697be786c9a5a6976b328c52d04
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec26m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 1sMaven dependency ordering for branch
+1 💚mvninstall12m 27smaster passed
+1 💚compile1m 10smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚compile1m 9smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚checkstyle1m 17smaster passed
+1 💚javadoc1m 20smaster passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc1m 10smaster passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+0 🆗spotbugs0m 47sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall0m 38sthe patch passed
+1 💚compile0m 39sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javac0m 39sthe patch passed
+1 💚compile0m 34sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚javac0m 34sthe patch passed
+1 💚checkstyle0m 22sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 34sthe patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚javadoc0m 34sthe patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚findbugs1m 36sthe patch passed
_ Other Tests _
+1 💚unit2m 18stez-api in the patch passed.
+1 💚unit0m 27stez-common in the patch passed.
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
62m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-294/2/artifact/out/Dockerfile
GITHUB PR#294
JIRA IssueTEZ-4473
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 7f857fc8594b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / d20f334
Default JavaPrivate Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-294/2/testReport/
Max. process+thread count592 (vs. ulimit of 5500)
modulesC: tez-api tez-common U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-294/2/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn

Copy link
Copy Markdown
MemberAuthor

@abstractdog
abstractdog self-requested a review June 23, 2023 09:34

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog
abstractdog merged commit 7e0448d into apache:masterJun 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog