Skip to content

TEZ-4508: Allow the FAIR_PARALLELISM mode to accept multiple source vertices - #306

Closed
okumin wants to merge 1 commit into
apache:masterfrom
okumin:TEZ-4508-fair-multiple
Closed

TEZ-4508: Allow the FAIR_PARALLELISM mode to accept multiple source vertices#306
okumin wants to merge 1 commit into
apache:masterfrom
okumin:TEZ-4508-fair-multiple

Conversation

@okumin

@okuminokumin commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

As explained in TEZ-4508, I expect there are valid use cases where FairShuffleVertexManager with FAIR_PARALLELISM should accept multiple SCATTER_GATHER edges.

throw new TezUncheckedException(
"Having more than one destination task process same partition(s) " +
"only works with one bipartite source.");
}

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this assertion is not must because Tez users currently use FairShuffleVertexManager in specific cases on purpose.
I guess we need to add a new DataMovementType or new FairShuffleVertexManager for JOIN, but we don't immediately need it.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec25m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall17m 2smaster passed
+1 💚compile0m 39smaster passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚compile0m 32smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚checkstyle1m 21smaster passed
+1 💚javadoc0m 43smaster passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 29smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+0 🆗spotbugs1m 32sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 31smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 22sthe patch passed
+1 💚compile0m 24sthe patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚javac0m 24sthe patch passed
+1 💚compile0m 21sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚javac0m 21sthe patch passed
-0 ⚠️checkstyle0m 15stez-runtime-library: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 19sthe patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 17sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚findbugs0m 58sthe patch passed
_ Other Tests _
+1 💚unit5m 31stez-runtime-library in the patch passed.
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
58m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-306/1/artifact/out/Dockerfile
GITHUB PR#306
JIRA IssueTEZ-4508
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux ee80f5606113 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 5beab4c
Default JavaPrivate Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-306/1/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-306/1/testReport/
Max. process+thread count1090 (vs. ulimit of 5500)
modulesC: tez-runtime-library U: tez-runtime-library
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-306/1/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdogabstractdog changed the title TEZ-4508: Allow the FAIR_PARALLELISM mode to accept multiple source v…TEZ-4508: Allow the FAIR_PARALLELISM mode to accept multiple source verticesDec 12, 2023
@okumin

Copy link
Copy Markdown
ContributorAuthor

While testing various cases, I found this might not work when amounts of unified vertices are uneven. I will close this one once.
https://github.com/apache/tez/blob/rel/release-0.10.3/tez-runtime-library/src/main/java/org/apache/tez/dag/library/vertexmanager/FairShuffleVertexManager.java#L443-L447

@okuminokumin closed this May 28, 2024
@okumin
okumin deleted the TEZ-4508-fair-multiple branch August 4, 2024 12:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@okumin@tez-yetus