Skip to content

TEZ-4110: Make Tez fail fast when DFS quota is exceeded. - #313

Merged
abstractdog merged 3 commits into
apache:masterfrom
ayushtkn:TEZ-4110
Oct 16, 2023
Merged

TEZ-4110: Make Tez fail fast when DFS quota is exceeded.#313
abstractdog merged 3 commits into
apache:masterfrom
ayushtkn:TEZ-4110

Conversation

@ayushtkn

@ayushtknayushtkn commented Oct 14, 2023

Copy link
Copy Markdown
Member

Tested on Hive.
Without Patch

----------------------------------------------------------------------------------------------
VERTICES MODE STATUS TOTAL COMPLETED RUNNING PENDING FAILED KILLED ----------------------------------------------------------------------------------------------
Map 1 container RUNNING 1 0 0 1 4 0 Reducer 2 container INITED 1 0 0 1 0 0 ----------------------------------------------------------------------------------------------
VERTICES: 00/02 [>>--------------------------] 0% ELAPSED TIME: 16.68 s ----------------------------------------------------------------------------------------------

With Patch

----------------------------------------------------------------------------------------------
VERTICES MODE STATUS TOTAL COMPLETED RUNNING PENDING FAILED KILLED ----------------------------------------------------------------------------------------------
Map 1 container RUNNING 1 0 0 1 1 0 Reducer 2 container INITED 1 0 0 1 0 0 ----------------------------------------------------------------------------------------------
VERTICES: 00/02 [>>--------------------------] 0% ELAPSED TIME: 5.52 s ----------------------------------------------------------------------------------------------

@ayushtkn

ayushtkn commented Oct 14, 2023

Copy link
Copy Markdown
MemberAuthor

Added the entire log output on the ticket:
With-Patch-Output
Without-Patch-Output

@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog

abstractdog commented Oct 15, 2023

Copy link
Copy Markdown
Contributor

thanks for this patch!
I can see that MAPREDUCE-7148 has a unit test for the corresponding change, would you consider adopting it to tez also?

@tez-yetus

tez-yetus commented Oct 15, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall10m 29smaster passed
+1 💚compile0m 26smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚compile0m 24smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚checkstyle1m 13smaster passed
+1 💚javadoc0m 32smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 20smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+0 🆗spotbugs1m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 5smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 13sthe patch passed
+1 💚compile0m 13sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javac0m 13sthe patch passed
+1 💚compile0m 12sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚javac0m 12sthe patch passed
-0 ⚠️checkstyle0m 8stez-runtime-internals: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 7sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 7sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚findbugs0m 28sthe patch passed
_ Other Tests _
+1 💚unit0m 38stez-runtime-internals in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
17m 50s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/2/artifact/out/Dockerfile
GITHUB PR#313
JIRA IssueTEZ-4110
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 5fd9d043d6b7 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 5bba1ff
Default JavaPrivate Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/2/artifact/out/diff-checkstyle-tez-runtime-internals.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/2/testReport/
Max. process+thread count100 (vs. ulimit of 5500)
modulesC: tez-runtime-internals U: tez-runtime-internals
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/2/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn

ayushtkn commented Oct 15, 2023

Copy link
Copy Markdown
MemberAuthor

Thanx @abstractdog I added some tests.

Checkstyle is kind of unavoidable, getting rid of that is overkill in the prod code for testing IMO

abstractdog
abstractdog reviewed Oct 16, 2023
View reviewed changes
Comment threadtez-runtime-internals/src/test/java/org/apache/tez/runtime/task/TestTaskExecution2.java Outdated
}

@Test
public void testClusterStoragaeCapacityFatalError() throws IOException {

@abstractdogabstractdogOct 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Storagae

@abstractdog

abstractdog commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

LGTM, only a typo

@abstractdog
abstractdog requested review from abstractdog and removed request for abstractdogOctober 16, 2023 07:49
@abstractdog
abstractdog merged commit 4bc87e2 into apache:masterOct 16, 2023
@tez-yetus

tez-yetus commented Oct 16, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall12m 55smaster passed
+1 💚compile0m 26smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚compile0m 25smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚checkstyle1m 18smaster passed
+1 💚javadoc0m 33smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 21smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+0 🆗spotbugs1m 6sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 13sthe patch passed
+1 💚compile0m 14sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javac0m 14sthe patch passed
+1 💚compile0m 12sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚javac0m 12sthe patch passed
-0 ⚠️checkstyle0m 8stez-runtime-internals: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 8sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 7sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚findbugs0m 27sthe patch passed
_ Other Tests _
+1 💚unit0m 38stez-runtime-internals in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
20m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/3/artifact/out/Dockerfile
GITHUB PR#313
JIRA IssueTEZ-4110
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 0f5c6f4dc5c8 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 5bba1ff
Default JavaPrivate Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/3/artifact/out/diff-checkstyle-tez-runtime-internals.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/3/testReport/
Max. process+thread count101 (vs. ulimit of 5500)
modulesC: tez-runtime-internals U: tez-runtime-internals
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-313/3/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractdogabstractdogabstractdog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog