Skip to content

TEZ-3821: Ability to fail fast tasks that write too much to local disk. - #314

Merged
abstractdog merged 4 commits into
apache:masterfrom
ayushtkn:TEZ-3821
Oct 27, 2023
Merged

TEZ-3821: Ability to fail fast tasks that write too much to local disk.#314
abstractdog merged 4 commits into
apache:masterfrom
ayushtkn:TEZ-3821

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

prevCounterSendHeartbeatNum = nonOobHeartbeatCounter.get();
}
try {
task.checkTaskLimits();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this in heartbeat can significantly increase its runtime. As in, even small increase of few milliseconds can have impact on cluster usage. You may want to run this every 10 seconds here or in some other way. This should ideally handle sorter spills and merges, in which case it can handle another ticket which was created on similar lines.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx Rajesh, there was some logic withHEAP_MEMORY_USAGE_UPDATE_INTERVAL, I used similar logic here to make sure the check happens at every 10 sec

@tez-yetus

This comment was marked as outdated.

@rbalamohan

Copy link
Copy Markdown
Contributor

Minor: change TaskLimitException to some other name, which can represent that limit is related to file bytes written.

Rest LGTM. + 1.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 58sMaven dependency ordering for branch
+1 💚mvninstall10m 56smaster passed
+1 💚compile0m 55smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚compile0m 52smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚checkstyle1m 2smaster passed
+1 💚javadoc1m 2smaster passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 51smaster passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+0 🆗spotbugs0m 36sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
+1 💚mvninstall0m 29sthe patch passed
+1 💚compile0m 30sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javac0m 30sthe patch passed
+1 💚compile0m 27sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚javac0m 27sthe patch passed
+1 💚checkstyle0m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 24sthe patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 25sthe patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚findbugs1m 8sthe patch passed
_ Other Tests _
+1 💚unit1m 57stez-api in the patch passed.
+1 💚unit0m 30stez-runtime-internals in the patch passed.
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
31m 15s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-314/5/artifact/out/Dockerfile
GITHUB PR#314
JIRA IssueTEZ-3821
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 73182c616adc 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 4bc87e2
Default JavaPrivate Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-314/5/testReport/
Max. process+thread count440 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-314/5/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit 51d6f53 into apache:masterOct 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ayushtkn@tez-yetus@rbalamohan@abstractdog