Skip to content

TEZ-4522: Use OpenFile where FileStatus is available. - #318

Merged
abstractdog merged 4 commits into
apache:masterfrom
ayushtkn:TEZ-4522
Dec 4, 2023
Merged

TEZ-4522: Use OpenFile where FileStatus is available.#318
abstractdog merged 4 commits into
apache:masterfrom
ayushtkn:TEZ-4522

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending tests

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 11sMaven dependency ordering for branch
+1 💚mvninstall11m 55smaster passed
+1 💚compile3m 12smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚compile2m 39smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚checkstyle2m 55smaster passed
+1 💚javadoc2m 32smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc2m 19smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 🆗spotbugs0m 36sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 42sthe patch passed
+1 💚compile1m 46sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javac1m 46sthe patch passed
+1 💚compile1m 36sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javac1m 36sthe patch passed
+1 💚checkstyle1m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 19sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc1m 16sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚findbugs4m 25sthe patch passed
_ Other Tests _
+1 💚unit2m 17stez-api in the patch passed.
+1 💚unit5m 34stez-runtime-library in the patch passed.
+1 💚unit1m 24stez-mapreduce in the patch passed.
+1 💚unit5m 12stez-dag in the patch passed.
+1 💚unit0m 13stez-tfile-parser in the patch passed.
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
90m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/artifact/out/Dockerfile
GITHUB PR#318
JIRA IssueTEZ-4522
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux d1cd837a6a68 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 0ed5e32
Default JavaPrivate Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

latest precommit looks good

@abstractdog
abstractdog merged commit 0c5cf68 into apache:masterDec 4, 2023
prabhjyotsingh added a commit to acceldata-io/tez that referenced this pull request Oct 22, 2024
…#318) (Ayush Saxena reviewed by Laszlo Bodor)"
This reverts commit 0c5cf68.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog