Skip to content

TEZ-4524 - Upgrade commons-codec to 1.15 - #321

Merged
abstractdog merged 1 commit into
apache:masterfrom
BilwaST:tez-4524
Jan 4, 2024
Merged

TEZ-4524 - Upgrade commons-codec to 1.15#321
abstractdog merged 1 commit into
apache:masterfrom
BilwaST:tez-4524

Conversation

@BilwaST

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec26m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 51smaster passed
+1 💚compile2m 17smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚compile2m 6smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javadoc1m 42smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc1m 10smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Patch Compile Tests _
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile2m 16sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javac2m 16sthe patch passed
+1 💚compile2m 4sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javac2m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc1m 11sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc1m 9sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Other Tests _
-1 ❌unit16m 8sroot in the patch failed.
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
80m 3s
ReasonTests
Failed junit teststez.dag.app.TestSpeculation
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-321/1/artifact/out/Dockerfile
GITHUB PR#321
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux d481752fbfd3 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 0c5cf68
Default JavaPrivate Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-321/1/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-321/1/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-321/1/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

@BilwaST thanks for the patch
can you please check if the failures are related to this upgrade?

@BilwaST

BilwaST commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@abstractdog I ran the failed UT locally and it passes. Its not related to my changes. Thank you

@abstractdog

Copy link
Copy Markdown
Contributor

TestSpeculation is flaky sometimes, I'll check and if it passes for me too, we can merge this I believe

@ayushtkn

Copy link
Copy Markdown
Member

I ran the test locally with this PR & it is passing for me

[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.tez.dag.app.TestSpeculation
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.274 s - in org.apache.tez.dag.app.TestSpeculation
[INFO] [INFO] Results:
[INFO] [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0

@abstractdog

Copy link
Copy Markdown
Contributor

cool, +1

@abstractdog
abstractdog self-requested a review January 4, 2024 14:39
@abstractdog
abstractdog merged commit 3bc73f3 into apache:masterJan 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@BilwaST@tez-yetus@abstractdog@ayushtkn