Skip to content

TEZ-4532: Remove KEYS file from git repo and source distribution - #329

Merged
ayushtkn merged 1 commit into
apache:masterfrom
zabetak:TEZ-4532
Jan 29, 2024
Merged

TEZ-4532: Remove KEYS file from git repo and source distribution#329
ayushtkn merged 1 commit into
apache:masterfrom
zabetak:TEZ-4532

Conversation

@zabetak

Copy link
Copy Markdown
Member

Projects must publish a KEYS file in their distribution directory which contains all public keys used to sign artifacts (i.e., https://dist.apache.org/repos/dist/release/tez/KEYS).

The KEYS file here is not serving any purpose since it shouldn't be used to verify releases. It adds maintenance overhead (assuming that is kept in sync) and possible confusion to the users with respect to which file they should use to validate the artifacts.

Projects must publish a KEYS file in their distribution directory which contains all public keys used to sign artifacts (i.e., https://dist.apache.org/repos/dist/release/tez/KEYS).
The KEYS file here is not serving any purpose since it shouldn't be used to verify releases. It adds maintenance overhead (assuming that is kept in sync) and possible confusion to the users with respect to which file they should use to validate the artifacts.
@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec25m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense1m 23sThe patch does not generate ASF License warnings.
28m 6s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-329/1/artifact/out/Dockerfile
GITHUB PR#329
JIRA IssueTEZ-4532
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux f39abfe0f548 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / d8dda5c
Max. process+thread count51 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-329/1/console
versionsgit=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn
ayushtkn merged commit 5e1cdee into apache:masterJan 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zabetak@tez-yetus@ayushtkn