Skip to content

TEZ-4536: Drop .txt suffix from LICENSE.txt and NOTICE.txt files - #330

Merged
abstractdog merged 1 commit into
apache:masterfrom
zabetak:TEZ-4536
Jan 25, 2024
Merged

TEZ-4536: Drop .txt suffix from LICENSE.txt and NOTICE.txt files#330
abstractdog merged 1 commit into
apache:masterfrom
zabetak:TEZ-4536

Conversation

@zabetak

@zabetakzabetak commented Jan 24, 2024

Copy link
Copy Markdown
Member

The .txt suffix is not forbidden however the preferred/suggested naming (https://www.apache.org/legal/apply-license.html#license-file-name) excludes suffix from LICENSE and NOTICE files.

Renamed using the following commands:

for i in `find . -name "NOTICE.txt"`; do mv $i "${i%.*}"; done
for i in `find . -name "LICENSE.txt"`; do mv $i "${i%.*}"; done

The .txt suffix is not forbidden however the preferred/suggested naming
(https://www.apache.org/legal/apply-license.html#license-file-name)
excludes suffix from LICENSE and NOTICE files.
@abstractdog
abstractdog self-requested a review January 24, 2024 10:41

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 36 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 38sMaven dependency ordering for branch
+1 💚mvninstall8m 8smaster passed
+1 💚javadoc3m 47smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc3m 53smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Patch Compile Tests _
+0 🆗mvndep0m 7sMaven dependency ordering for patch
+1 💚mvninstall6m 4sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc3m 33sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc4m 0sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Other Tests _
+1 💚unit2m 1stez-api in the patch passed.
+1 💚unit0m 28stez-common in the patch passed.
+1 💚unit0m 37stez-runtime-internals in the patch passed.
+1 💚unit4m 20stez-runtime-library in the patch passed.
+1 💚unit1m 7stez-mapreduce in the patch passed.
+1 💚unit0m 19stez-examples in the patch passed.
+1 💚unit4m 19stez-dag in the patch passed.
+1 💚unit37m 2stez-tests in the patch passed.
+1 💚unit1m 1stez-ui in the patch passed.
+1 💚unit1m 28stez-yarn-timeline-history in the patch passed.
+1 💚unit0m 18stez-yarn-timeline-cache-plugin in the patch passed.
+1 💚unit1m 29stez-yarn-timeline-history-with-fs in the patch passed.
+1 💚unit0m 17stez-dist in the patch passed.
+1 💚unit62m 54sroot in the patch passed.
+1 💚asflicense3m 44sThe patch does not generate ASF License warnings.
158m 42s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/artifact/out/Dockerfile
GITHUB PR#330
JIRA IssueTEZ-4536
Optional Testsdupname asflicense shellcheck shelldocs javac javadoc unit
unameLinux 71e9a32d8d6e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 5a2df54
Default JavaPrivate Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ui tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-cache-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-dist . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/console
versionsgit=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit 5b4e827 into apache:masterJan 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zabetak@tez-yetus@abstractdog