Skip to content

TEZ-4538 : Upgrade netty to 4.1.100 due to CVE-2023-44487 - #333

Merged
abstractdog merged 1 commit into
apache:masterfrom
AnmolSun:nettyUp
Jan 29, 2024
Merged

TEZ-4538 : Upgrade netty to 4.1.100 due to CVE-2023-44487#333
abstractdog merged 1 commit into
apache:masterfrom
AnmolSun:nettyUp

Conversation

@AnmolSun

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec25m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 1sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 28smaster passed
+1 💚compile2m 26smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚compile2m 14smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javadoc1m 42smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc1m 8smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Patch Compile Tests _
+1 💚mvninstall4m 46sthe patch passed
+1 💚compile2m 24sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javac2m 24sthe patch passed
+1 💚compile2m 10sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javac2m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 12sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc1m 7sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Other Tests _
+1 💚unit72m 13sroot in the patch passed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
136m 26s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-333/1/artifact/out/Dockerfile
GITHUB PR#333
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 41b2609f4ebd 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 5b4e827
Default JavaPrivate Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-333/1/testReport/
Max. process+thread count1493 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-333/1/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

thanks @AnmolSun , can you please create a Jira for this one?

@AnmolSunAnmolSun changed the title Upgrade netty to 4.1.100 due to CVE-2023-44487TEZ-4538 : Upgrade netty to 4.1.100 due to CVE-2023-44487Jan 29, 2024
@AnmolSun
AnmolSun marked this pull request as ready for review January 29, 2024 08:55
@AnmolSun

Copy link
Copy Markdown
ContributorAuthor

Hi @abstractdog ,
Please find the JIIRA - TEZ-4538
Thanks a lot.

@abstractdog

Copy link
Copy Markdown
Contributor

thanks @AnmolSun! does it make sense to the current latest 106.Final ?

@AnmolSun

Copy link
Copy Markdown
ContributorAuthor

Hi @abstractdog , Hadoop is also currently at 4.1.100.Final (Ref). To avoid any conflicts, I thought it would be better to be in sync with what Hadoop is using currently, since that version also does not have any vulnerabilities. I will also work on raising it with Hive as well to upgrade their netty version to 4.1.100.Final as well.

@abstractdog

Copy link
Copy Markdown
Contributor

makes sense
+1

@abstractdog
abstractdog self-requested a review January 29, 2024 09:10

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog
abstractdog merged commit 8c0884d into apache:masterJan 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AnmolSun@tez-yetus@abstractdog