Skip to content

TEZ-4542: Tez application may fail due to int overflow when record size is large and sort memory is low. - #336

Merged
abstractdog merged 1 commit into
apache:masterfrom
zhengchenyu:TEZ-4542
May 14, 2024
Merged

TEZ-4542: Tez application may fail due to int overflow when record size is large and sort memory is low.#336
abstractdog merged 1 commit into
apache:masterfrom
zhengchenyu:TEZ-4542

Conversation

@zhengchenyu

Copy link
Copy Markdown
Contributor

See TEZ-4542 for details.

@tez-yetus

This comment was marked as outdated.

@zhengchenyu
zhengchenyu deleted the TEZ-4542 branch February 23, 2024 08:52
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec24m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall16m 35smaster passed
+1 💚compile0m 36smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚compile0m 34smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚checkstyle1m 31smaster passed
+1 💚javadoc0m 49smaster passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 31smaster passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 🆗spotbugs1m 42sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 40smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 22sthe patch passed
+1 💚compile0m 23sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javac0m 23sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚javac0m 20sthe patch passed
+1 💚checkstyle0m 17sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 19sthe patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚javadoc0m 18sthe patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚findbugs0m 57sthe patch passed
_ Other Tests _
+1 💚unit9m 27stez-runtime-library in the patch passed.
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
60m 10s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-336/4/artifact/out/Dockerfile
GITHUB PR#336
JIRA IssueTEZ-4542
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux e6c6a2d8c92f 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f8c2e11
Default JavaPrivate Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-336/4/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: tez-runtime-library U: tez-runtime-library
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-336/4/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Can you please review this PR?

@abstractdog

abstractdog commented May 13, 2024

Copy link
Copy Markdown
Contributor

the affected lines were touched by @rbalamohan in the past frequently, he is the PipelinedSorter expert, is there a chance you can take a look at this tiny patch?

@rbalamohan

Copy link
Copy Markdown
Contributor

LGTM. +1.

BTW, pipelinesorter is the brainchild of @t3rmin4t0r . :)

@abstractdog
abstractdog merged commit 642f4c0 into apache:masterMay 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zhengchenyu@tez-yetus@abstractdog@rbalamohan