Skip to content

TEZ-4550. Upgrade commons-cli to 1.6.0. - #343

Merged
abstractdog merged 3 commits into
apache:masterfrom
slfan1989:TEZ-4550
Aug 9, 2024
Merged

TEZ-4550. Upgrade commons-cli to 1.6.0.#343
abstractdog merged 3 commits into
apache:masterfrom
slfan1989:TEZ-4550

Conversation

@slfan1989

@slfan1989slfan1989 commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

JIRA: TEZ-4550. Upgrade commons-cli to 1.6.0.

@tez-yetus

tez-yetus commented Apr 4, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 7smaster passed
+1 💚compile2m 19smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚compile2m 7smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javadoc1m 50smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc1m 12smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 💚mvninstall4m 15sthe patch passed
+1 💚compile2m 18sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javac2m 18sthe patch passed
+1 💚compile2m 8sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javac2m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc1m 21sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc1m 12sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 ❌unit49m 30sroot in the patch failed.
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
106m 40s
ReasonTests
Failed junit teststez.test.TestAMRecovery
tez.test.TestRecovery
tez.test.TestDAGRecovery
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/artifact/out/Dockerfile
GITHUB PR#343
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 88cb281869f2 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f080031
Default JavaPrivate Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/testReport/
Max. process+thread count1309 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

tez-yetus commented May 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 59smaster passed
+1 💚compile2m 26smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚compile2m 7smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javadoc1m 45smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc1m 13smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile2m 17sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javac2m 17sthe patch passed
+1 💚compile2m 10sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javac2m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc1m 12sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc1m 12sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 ❌unit50m 28sroot in the patch failed.
+1 💚asflicense0m 41sThe patch does not generate ASF License warnings.
87m 22s
ReasonTests
Failed junit teststez.test.TestAMRecovery
tez.test.TestRecovery
tez.test.TestDAGRecovery
tez.test.TestTezJobs
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/artifact/out/Dockerfile
GITHUB PR#343
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux a2777bec9310 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 906059a
Default JavaPrivate Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented May 6, 2024

Copy link
Copy Markdown
Contributor

@slfan1989 : can you please check if TestTezJobs failures are related? the rest is TEZ-4559

@slfan1989

slfan1989 commented May 7, 2024

Copy link
Copy Markdown
ContributorAuthor

@slfan1989 : can you please check if TestTezJobs failures are related? the rest is TEZ-4559

Thank you for the review! I will follow up and check the reasons for the failure of TestTezJobs.

@abstractdog

abstractdog commented Aug 4, 2024

Copy link
Copy Markdown
Contributor

tez release 0.10.4 is very soon to be started, shall we postpone this to the next release?

@slfan1989

slfan1989 commented Aug 6, 2024

Copy link
Copy Markdown
ContributorAuthor

tez release 0.10.4 is very soon to be started, shall we postpone this to the next release?

I will continue to improve this pull request.

@tez-yetus

tez-yetus commented Aug 9, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 45smaster passed
+1 💚compile2m 21smaster passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚compile2m 14smaster passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
+1 💚javadoc1m 44smaster passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚javadoc1m 13smaster passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
-0 ⚠️patch25m 50sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile2m 22sthe patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚javac2m 22sthe patch passed
+1 💚compile2m 13sthe patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
+1 💚javac2m 13sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc1m 12sthe patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚javadoc1m 11sthe patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
_ Other Tests _
+1 💚unit81m 36sroot in the patch passed.
+1 💚asflicense0m 41sThe patch does not generate ASF License warnings.
142m 38s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/artifact/out/Dockerfile
GITHUB PR#343
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux ac1be36a4893 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 563b494
Default JavaPrivate Build-1.8.0_422-8u422-b05-1~22.04-b05
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~22.04-b05
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989

slfan1989 commented Aug 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Can you help review this pr again? Thank you very much!

@abstractdog
abstractdog self-requested a review August 9, 2024 11:20
abstractdog
abstractdog approved these changes Aug 9, 2024
View reviewed changes

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog
abstractdog merged commit cd6ceec into apache:masterAug 9, 2024
@slfan1989

slfan1989 commented Aug 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Thanks for the review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractdogabstractdogabstractdog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slfan1989@tez-yetus@abstractdog