Skip to content

TEZ-4555: Fail fast in LocalClient if the dirs (log, local) haven't been created - #348

Merged
ayushtkn merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4555
Apr 25, 2024
Merged

TEZ-4555: Fail fast in LocalClient if the dirs (log, local) haven't been created#348
ayushtkn merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4555

Conversation

@abstractdog

@abstractdogabstractdog commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

This PR is about to make LocalClient fail fast if it cannot create the folders instead of going on and failing later in a confusing way. See Jira for details.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 33smaster passed
+1 💚compile0m 43smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚compile0m 40smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚checkstyle1m 29smaster passed
+1 💚javadoc0m 36smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc0m 23smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 🆗spotbugs1m 45sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 43smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 28sthe patch passed
+1 💚compile0m 29sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javac0m 29sthe patch passed
+1 💚compile0m 25sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javac0m 25sthe patch passed
+1 💚checkstyle0m 19sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 9sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc0m 9sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚findbugs1m 11sthe patch passed
_ Other Tests _
+1 💚unit5m 19stez-dag in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
52m 22s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-348/1/artifact/out/Dockerfile
GITHUB PR#348
JIRA IssueTEZ-4555
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux ce2f748e3c8f 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f080031
Default JavaPrivate Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-348/1/testReport/
Max. process+thread count252 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-348/1/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn
ayushtkn merged commit b5b6226 into apache:masterApr 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn