Skip to content

TEZ-4557: Revert TEZ-4303, NoClassDefFoundError because of missing httpclient jar - #349

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:httpclient
Jun 28, 2024
Merged

TEZ-4557: Revert TEZ-4303, NoClassDefFoundError because of missing httpclient jar#349
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:httpclient

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

Please refer to TEZ-4557, for error stacktrace.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@abstractdog, can you please review this?

@abstractdog

Copy link
Copy Markdown
Contributor

@abstractdog, can you please review this?

according to my jira comment, I'm about to approve this
can you rebase your PR on top of master @Aggarwal-Raghav to get a green precommit test run

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Rebased. Thanks for the review @abstractdog.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Will force push the commit again, as there is failure in git workflows. Error seems unrelated to the patch.
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.8.0:install-node-and-yarn (install node and yarn) on project tez-ui: Could not download Node.js: Got error code 500 from the server. -> [Help 1]

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Test seems to be passing on local
Screenshot 2024-06-25 at 7 24 51 PM

will trigger the CI one more time!

@abstractdog

Copy link
Copy Markdown
Contributor

Test seems to be passing on local Screenshot 2024-06-25 at 7 24 51 PM

will trigger the CI one more time!

TestAnalyzer is flaky

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Wasn't aware of it, have triggered it now 🥲.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall16m 45smaster passed
+1 💚compile2m 16smaster passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚compile2m 3smaster passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 💚javadoc1m 45smaster passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚javadoc1m 9smaster passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
_ Patch Compile Tests _
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile2m 14sthe patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚javac2m 14sthe patch passed
+1 💚compile2m 4sthe patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 💚javac2m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 11sthe patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚javadoc1m 10sthe patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
_ Other Tests _
-1 ❌unit61m 10sroot in the patch failed.
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
98m 5s
ReasonTests
Failed junit teststez.test.TestRecovery
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/artifact/out/Dockerfile
GITHUB PR#349
JIRA IssueTEZ-4557
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux c67e5978f752 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 19b2351
Default JavaPrivate Build-1.8.0_412-8u412-ga-1~22.04.1-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/testReport/
Max. process+thread count2100 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@deniskuzZ

deniskuzZ commented Jun 27, 2024

Copy link
Copy Markdown
Member

@abstractdog, is there a possibility of Tez release that includes this fix before Hive-4.0.1
cc @ayushtkn, @dengzhhu653

@abstractdog

Copy link
Copy Markdown
Contributor

@abstractdog, is there a possibility of Tez release that includes this fix before Hive-4.0.1 cc @ayushtkn, @dengzhhu653

not sure, even if we merge this now, and initiate a release process for Tez 0.10.4, it's a matter of weeks, usually at least a month until we get PMC member votes

@abstractdog
abstractdog self-requested a review June 28, 2024 03:59
@abstractdog

Copy link
Copy Markdown
Contributor

ignoring any further recovery flaky failures, merging this to master

@abstractdog
abstractdog merged commit c745edf into apache:masterJun 28, 2024
@Aggarwal-Raghav
Aggarwal-Raghav deleted the httpclient branch March 19, 2026 08:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Aggarwal-Raghav@tez-yetus@abstractdog@deniskuzZ