Skip to content

TEZ-4589: Counter for the overall duration of succeeded/failed/killed task attempts - #382

Merged
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4589
Nov 23, 2024
Merged

TEZ-4589: Counter for the overall duration of succeeded/failed/killed task attempts#382
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4589

Conversation

@abstractdog

@abstractdogabstractdog commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

tested on cluster with different scenarios, hive LLAP

  1. 2 queries running in parallel, leading to task kills, also I killed random nodes during the test
INFO : Run DAG 149.16s
INFO : NUM_FAILED_TASKS: 18
INFO : NUM_KILLED_TASKS: 11078
INFO : NUM_SUCCEEDED_TASKS: 774
INFO : TOTAL_LAUNCHED_TASKS: 11870
INFO : DURATION_FAILED_TASKS_MILLIS: 125559
INFO : DURATION_KILLED_TASKS_MILLIS: 2474797
INFO : DURATION_SUCCEEDED_TASKS_MILLIS: 15740900
ratio of failed to succeeded durations: 0.0080 = 0.80%
ratio of killed to succeeded durations: 0.1575 = 15.75%

low killed/succeeded ratio implies the hive LLAP behavior (task preempted quite fast, 11078 task kills didn't contributed that much)

  1. single query, but more aggressive node killing
INFO : Run DAG 392.71s
INFO : NUM_FAILED_TASKS: 210
INFO : NUM_KILLED_TASKS: 334
INFO : NUM_SUCCEEDED_TASKS: 880
INFO : TOTAL_LAUNCHED_TASKS: 1318
INFO : DURATION_FAILED_TASKS_MILLIS: 14433036
INFO : DURATION_KILLED_TASKS_MILLIS: 12815980
INFO : DURATION_SUCCEEDED_TASKS_MILLIS: 31076258
ratio of failed to succeeded durations: 0.4643 = 46.43%
ratio of killed to succeeded durations: 0.4117 = 41.17%

btw, this time, task kills were in the early started Reducer5 tasks, as many Map 4 source tasks have failed (so reducer considered unhealthy most probably):

----------------------------------------------------------------------------------------------
VERTICES MODE STATUS TOTAL COMPLETED RUNNING PENDING FAILED KILLED
----------------------------------------------------------------------------------------------
Map 2 .......... llap SUCCEEDED 1 1 0 0 0 0
Map 1 .......... llap SUCCEEDED 1 1 0 0 0 0
Map 3 .......... llap SUCCEEDED 5 5 0 0 1 0
Map 4 .......... llap SUCCEEDED 675 675 0 0 209 0
Reducer 5 ...... llap SUCCEEDED 92 92 0 0 0 334 ----------------------------------------------------------------------------------------------
VERTICES: 05/05 [==========================>>] 100% ELAPSED TIME: 394.27 s
----------------------------------------------------------------------------------------------
  1. normal query, no contention, no node failures
INFO : NUM_SUCCEEDED_TASKS: 774
INFO : TOTAL_LAUNCHED_TASKS: 774
INFO : DURATION_SUCCEEDED_TASKS_MILLIS: 15253902

@abstractdog
abstractdogforce-pushed the TEZ-4589 branch 3 times, most recently from 2f0af7c to 411e095CompareNovember 21, 2024 09:07
@apacheapache deleted a comment from tez-yetusNov 21, 2024
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdogabstractdog changed the title TEZ-4589: Counter for the overall duration of failed/killed task attemptsTEZ-4589: Counter for the overall duration of succeeded/failed/killed task attemptsNov 21, 2024
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep6m 3sMaven dependency ordering for branch
+1 💚mvninstall11m 6smaster passed
+1 💚compile0m 48smaster passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚compile0m 47smaster passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚checkstyle1m 10smaster passed
+1 💚javadoc0m 56smaster passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 43smaster passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+0 🆗spotbugs0m 45sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 7sMaven dependency ordering for patch
+1 💚mvninstall0m 32sthe patch passed
+1 💚compile0m 31sthe patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javac0m 31sthe patch passed
+1 💚compile0m 28sthe patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚javac0m 28sthe patch passed
+1 💚checkstyle0m 18sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 19sthe patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 24sthe patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚findbugs1m 23sthe patch passed
_ Other Tests _
+1 💚unit1m 57stez-api in the patch passed.
+1 💚unit4m 14stez-dag in the patch passed.
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
35m 14s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-382/9/artifact/out/Dockerfile
GITHUB PR#382
JIRA IssueTEZ-4589
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 2b0776be3846 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 53309ea
Default JavaPrivate Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-382/9/testReport/
Max. process+thread count645 (vs. ulimit of 5500)
modulesC: tez-api tez-dag U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-382/9/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit b5bf8dc into apache:masterNov 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn