TEZ-4594. Tez shuffle handler should not shade and relocate javax packages

[jteagles]

No description provided.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	21m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	8m 28s	master passed
+1 💚	compile	0m 31s	master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	compile	0m 31s	master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚	javadoc	0m 54s	master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 23s	master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s	the patch passed
+1 💚	compile	0m 16s	the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javac	0m 16s	the patch passed
+1 💚	compile	0m 15s	the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚	javac	0m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 9s	the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 9s	the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
		_ Other Tests _
+1 💚	unit	2m 55s	tez-aux-services in the patch passed.
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		37m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-385/1/artifact/out/Dockerfile
GITHUB PR	#385
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 581041a1d4a7 5.15.0-126-generic #136-Ubuntu SMP Wed Nov 6 10:38:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / ca15119
Default Java	Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-385/1/testReport/
Max. process+thread count	1552 (vs. ulimit of 5500)
modules	C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-385/1/console
versions	git=2.34.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[okumin]

I can see the following jars are currently relocated.

• org/apache/tez/shaded/javax/annotation/
• org/apache/tez/shaded/javax/xml/bind/

I guess they come from Hadoop. So, "As javax is part of the jdk:" in the ticket might not be correct. Personally, I don't have any objections to exclude javax, though

+- org.apache.hadoop:hadoop-yarn-api:jar:3.3.6:provided
| +- javax.xml.bind:jaxb-api:jar:2.2.11:compile

[jteagles]

@okumin , thanks for the clarification
@abstractdog , @okumin is there any other change needed before +1?

[abstractdog]

I'm fine with this change +1