Skip to content

TEZ-4603: Bucket Map Join can hang if the source vertex parallelism i… - #391

Closed
mayankkunwar wants to merge 1 commit into
apache:branch-0.10.4from
mayankkunwar:TEZ-4603
Closed

TEZ-4603: Bucket Map Join can hang if the source vertex parallelism i…#391
mayankkunwar wants to merge 1 commit into
apache:branch-0.10.4from
mayankkunwar:TEZ-4603

Conversation

@mayankkunwar

@mayankkunwarmayankkunwar commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

…s changed by reducer autoparallelism
Description
The changes in this PR are w.r.t. when auto reduce parallelism kicks in, we try to updates downstream vertex's expected number of input, so that the execution hang could be avoided.
In this case, the type of edge between reducer and downstream vertices (Mapper) is a CUSTOM edge.
[Reducer --(C)--> Mapper]

TODO: Unit Tests

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec25m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-0.10.4 Compile Tests _
+0 🆗mvndep7m 6sMaven dependency ordering for branch
+1 💚mvninstall15m 48sbranch-0.10.4 passed
+1 💚compile1m 55sbranch-0.10.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚compile1m 44sbranch-0.10.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚checkstyle2m 7sbranch-0.10.4 passed
+1 💚javadoc1m 51sbranch-0.10.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc1m 29sbranch-0.10.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗spotbugs1m 19sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 7sbranch-0.10.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 8sthe patch passed
+1 💚compile1m 21sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javac1m 21sthe patch passed
+1 💚compile1m 7sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚javac1m 7sthe patch passed
-0 ⚠️checkstyle0m 15stez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 53sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 51sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌findbugs1m 15stez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚unit2m 17stez-api in the patch passed.
+1 💚unit8m 39stez-runtime-library in the patch passed.
+1 💚unit4m 51stez-dag in the patch passed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
89m 6s
ReasonTests
FindBugsmodule:tez-dag
Load of known null value in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:[line 2004]
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-391/1/artifact/out/Dockerfile
GITHUB PR#391
JIRA IssueTEZ-4603
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux ff1045aac604 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionbranch-0.10.4 / 5b5fff6
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-391/1/artifact/out/diff-checkstyle-tez-runtime-library.txt
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-391/1/artifact/out/new-findbugs-tez-dag.html
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-391/1/testReport/
Max. process+thread count1090 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-dag U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-391/1/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mayankkunwar

Copy link
Copy Markdown
ContributorAuthor

Closing this PR, will create a similar PR for master branch

@mayankkunwar
mayankkunwar deleted the TEZ-4603 branch February 19, 2025 04:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mayankkunwar@tez-yetus