Skip to content

TEZ-4604: tez-mapreduce does not delete files under staging directory - #395

Open
okumin wants to merge 3 commits into
apache:masterfrom
okumin:TEZ-4604-mr-tez
Open

TEZ-4604: tez-mapreduce does not delete files under staging directory#395
okumin wants to merge 3 commits into
apache:masterfrom
okumin:TEZ-4604-mr-tez

Conversation

@okumin

Copy link
Copy Markdown
Contributor

try {
dagAMConf.set(TezConfiguration.TEZ_AM_STAGING_DIR,
jobSubmitDir);
dagAMConf.setBoolean(TezConfiguration.TEZ_AM_STAGING_BASE_DIR_CLEANUP, true);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YARNRunner is a glue code between a MapReduce Job and Tez, implementing ClientProtocol. So, the client code of YARNRunner is Apache Hadoop.
ClientProtocol doesn't have an API to declare that a specific job has been completed. If we resolve this issue on the client side, we have to add new APIs to Apache Hadoop. That's why I added a new param and handled the issue on Apache Tez side.
I'm not confident that this approach is the best. I'd appreciate it if someone could give me a better idea.

@okuminokumin changed the title [WIP] TEZ-4604: tez-mapreduce does not delete files under staging directoryTEZ-4604: tez-mapreduce does not delete files under staging directoryFeb 28, 2025
@okumin
okumin marked this pull request as ready for review February 28, 2025 09:27
@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep2m 3sMaven dependency ordering for branch
+1 💚mvninstall9m 58smaster passed
+1 💚compile2m 27smaster passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚compile2m 19smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚checkstyle2m 5smaster passed
+1 💚javadoc2m 1smaster passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc1m 51smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗spotbugs0m 46sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 13smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 28sthe patch passed
+1 💚compile1m 30sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javac1m 30sthe patch passed
+1 💚compile1m 22sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚javac1m 22sthe patch passed
+1 💚checkstyle0m 55sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 59sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 59sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚findbugs3m 34sthe patch passed
_ Other Tests _
+1 💚unit2m 11stez-api in the patch passed.
+1 💚unit1m 22stez-mapreduce in the patch passed.
+1 💚unit5m 5stez-dag in the patch passed.
-1 ❌unit51m 37stez-tests in the patch failed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
123m 54s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-395/2/artifact/out/Dockerfile
GITHUB PR#395
JIRA IssueTEZ-4604
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 3f45da27f7c5 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 3aa2aa1
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-395/2/artifact/out/patch-unit-tez-tests.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-395/2/testReport/
Max. process+thread count1303 (vs. ulimit of 5500)
modulesC: tez-api tez-mapreduce tez-dag tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-395/2/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@okumin@tez-yetus