Uh oh!
There was an error while loading. Please reload this page.
TEZ-4014: Allow DAGAppMaster to read configuration from plaintext (1/3) - #408
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
commented
Aug 22, 2025
ContributorAuthor
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
+308
to
+328
| assertEquals(conf.get("tez.lib.uris"), "tez.tar.gz"); | ||
| } | ||
| @Test(timeout = 5000) | ||
| public void testPluginsDescriptorFromJSON() throws IOException { | ||
| InputStream is = ClassLoader.getSystemResourceAsStream(TezConstants.SERVICE_PLUGINS_DESCRIPTOR_JSON); | ||
| ServicePluginsDescriptor spd = TezClientUtils.createPluginsDescriptorFromJSON(is); | ||
| TaskSchedulerDescriptor tsd = spd.getTaskSchedulerDescriptors()[0]; | ||
| ContainerLauncherDescriptor cld = spd.getContainerLauncherDescriptors()[0]; | ||
| TaskCommunicatorDescriptor tcd = spd.getTaskCommunicatorDescriptors()[0]; | ||
| assertFalse(spd.areContainersEnabled()); | ||
| assertTrue(spd.isUberEnabled()); | ||
| assertEquals(tsd.getClassName(), "testScheduler0_class"); | ||
| assertEquals(tsd.getEntityName(), "testScheduler0"); | ||
| assertEquals(cld.getClassName(), "testLauncher0_class"); | ||
| assertEquals(cld.getEntityName(), "testLauncher0"); | ||
| assertEquals(tcd.getClassName(), "testComm0_class"); | ||
| assertEquals(tcd.getEntityName(), "testComm0"); | ||
| assertEquals(tcd.getUserPayload().getVersion(), 1); | ||
| assertArrayEquals(tcd.getUserPayload().deepCopyAsArray(), new byte[] {0, 0, 0, 1}); |
Member
There was a problem hiding this comment.
can you check the order of arguments in assertEquals, the expected in first argument actual is second, I think it is opposite here
ContributorAuthor
There was a problem hiding this comment.
good catch, let me fix
| } | ||
| } | ||
| public static Configuration readTezConfigurationXml(InputStream is) throws IOException { |
| return configuration; | ||
| } | ||
| public static ConfigurationProto loadConfProtoFromText() throws IOException { |
Member
There was a problem hiding this comment.
which method call this? this shows as unused. Removing it doesn't make any test fail either
ContributorAuthor
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
Sep 1, 2025
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.