Skip to content

TEZ-4631: Include an official script that installs hadoop and tez andruns a simple example DAG - addendum ASF license + shellcheck fixes - #417

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4631-addendum
Jun 4, 2025

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@abstractdog
abstractdog requested a review from ayushtknJune 3, 2025 08:35
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec26m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep2m 4sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚codespell0m 4sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
-1 ❌shellcheck0m 0s/results-shellcheck.txtThe patch generated 24 new + 0 unchanged - 0 fixed = 24 total (was 0)
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
29m 9s
SubsystemReport/Notes
DockerClientAPI=1.50 ServerAPI=1.50 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/1/artifact/out/Dockerfile
GITHUB PR#417
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs
unameLinux 2105b864b3ee 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-417/src/.yetus/personality.sh
git revisionmaster / e0656fe
Max. process+thread count58 (vs. ulimit of 5500)
modulesC: U:
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/1/console
versionsgit=2.34.1 maven=3.6.3 codespell=2.0.0 shellcheck=0.7.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

LOL, shellcheck passed in the original PR #414
anyway, I'm trying to fix these if possible

@abstractdogabstractdog changed the title TEZ-4631: Include an official script that installs hadoop and tez andruns a simple example DAG - addendum ASF licenseTEZ-4631: Include an official script that installs hadoop and tez andruns a simple example DAG - addendum ASF license + shellcheck fixesJun 3, 2025
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep2m 7sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚codespell0m 5sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
-1 ❌shellcheck0m 1s/results-shellcheck.txtThe patch generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
4m 0s
SubsystemReport/Notes
DockerClientAPI=1.50 ServerAPI=1.50 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/2/artifact/out/Dockerfile
GITHUB PR#417
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs
unameLinux 0ea9bc6c6f37 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-417/src/.yetus/personality.sh
git revisionmaster / 5be0073
Max. process+thread count56 (vs. ulimit of 5500)
modulesC: U:
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/2/console
versionsgit=2.34.1 maven=3.6.3 codespell=2.0.0 shellcheck=0.7.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

This comment was marked as outdated.

… runs a simple example DAG (apache#414) - addendum ASF license
@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep1m 58sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚codespell0m 6sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 0sNo new issues.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 4s
SubsystemReport/Notes
DockerClientAPI=1.50 ServerAPI=1.50 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/4/artifact/out/Dockerfile
GITHUB PR#417
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs
unameLinux 5ffa699bcfa8 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-417/src/.yetus/personality.sh
git revisionmaster / 6ea0d62
Max. process+thread count55 (vs. ulimit of 5500)
modulesC: U:
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-417/4/console
versionsgit=2.34.1 maven=3.6.3 codespell=2.0.0 shellcheck=0.7.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@ayushtkn : can you pls check? this is green now

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
abstractdog merged commit b0a65ec into apache:masterJun 4, 2025
@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks a lot @ayushtkn for reviewing this one!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn