Skip to content

TEZ-4647: Refactor plugin management from DAGAppMaster - #428

Merged
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4647
Sep 15, 2025
Merged

TEZ-4647: Refactor plugin management from DAGAppMaster#428
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4647

Conversation

@abstractdog

@abstractdogabstractdog commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

From Jira:

The proposal is to create a PluginManager to offload much of the plugin management code from the already overloaded DAGAppMaster class (including its static methods).
This issue was discovered while working on TEZ-4007, which only exacerbated the situation with the addition of AMExtensions (not AMExtensions themselves, but rather the original code in DAGAppMaster). Let’s clean this up first before proceeding with TEZ-4007.

Testing done with affected unit tests
mvn install -Dtest=TestTaskSchedulerManager,TestVertexImpl2,TestDAGAppMaster -pl ./tez-dag

@abstractdog
abstractdogforce-pushed the TEZ-4647 branch 4 times, most recently from 997d249 to a38ec96CompareSeptember 12, 2025 09:00
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec25m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall11m 49smaster passed
+1 💚compile0m 46smaster passed
+1 💚checkstyle1m 5smaster passed
+1 💚javadoc0m 34smaster passed
+0 🆗spotbugs2m 33stez-dag in master has 785 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall0m 33sthe patch passed
+1 💚codespell0m 32sNo new issues.
+1 💚compile0m 31sthe patch passed
+1 💚javac0m 31sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 17stez-dag: The patch generated 0 new + 105 unchanged - 1 fixed = 105 total (was 106)
+1 💚javadoc0m 13sthe patch passed
+1 💚spotbugs1m 52sthe patch passed
_ Other Tests _
+1 💚unit5m 7stez-dag in the patch passed.
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
52m 55s
SubsystemReport/Notes
DockerClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/9/artifact/out/Dockerfile
GITHUB PR#428
Optional Testsdupname asflicense codespell detsecrets xmllint javac javadoc unit spotbugs checkstyle compile
unameLinux 6eaece3b1b08 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-428/src/.yetus/personality.sh
git revisionmaster / f0c4020
Default JavaUbuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/9/testReport/
Max. process+thread count243 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/9/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

public static void addDescriptor(List<NamedEntityDescriptor> list, BiMap<String, Integer> pluginMap,
NamedEntityDescriptor namedEntityDescriptor) {
list.add(namedEntityDescriptor);
pluginMap.put(list.get(list.size() - 1).getEntityName(), list.size() - 1);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do getLast instead of size -1

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, absolutely

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗xmllint0m 1sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall11m 38smaster passed
+1 💚compile0m 45smaster passed
+1 💚checkstyle1m 5smaster passed
+1 💚javadoc0m 34smaster passed
+0 🆗spotbugs2m 35stez-dag in master has 785 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall0m 32sthe patch passed
+1 💚codespell0m 32sNo new issues.
+1 💚compile0m 32sthe patch passed
+1 💚javac0m 32sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 17stez-dag: The patch generated 0 new + 105 unchanged - 1 fixed = 105 total (was 106)
+1 💚javadoc0m 12sthe patch passed
+1 💚spotbugs1m 51sthe patch passed
_ Other Tests _
+1 💚unit5m 5stez-dag in the patch passed.
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
27m 46s
SubsystemReport/Notes
DockerClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/10/artifact/out/Dockerfile
GITHUB PR#428
Optional Testsdupname asflicense codespell detsecrets xmllint javac javadoc unit spotbugs checkstyle compile
unameLinux b36734937aa2 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-428/src/.yetus/personality.sh
git revisionmaster / 250a0e2
Default JavaUbuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/10/testReport/
Max. process+thread count243 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-428/10/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks @ayushtkn for the review, I'm merging this soon after addressing your comment

@abstractdog
abstractdog merged commit 261362e into apache:masterSep 15, 2025
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn