Skip to content

TEZ-4659: Refactoring minor issues in profile output servlet - #439

Merged
ayushtkn merged 2 commits into
apache:masterfrom
ayushtkn:pathvalidate
Oct 31, 2025
Merged

TEZ-4659: Refactoring minor issues in profile output servlet#439
ayushtkn merged 2 commits into
apache:masterfrom
ayushtkn:pathvalidate

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

No description provided.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec27m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep2m 6sMaven dependency ordering for branch
+1 💚mvninstall10m 26smaster passed
+1 💚compile1m 7smaster passed
+1 💚checkstyle1m 7smaster passed
+1 💚javadoc1m 1smaster passed
+0 🆗spotbugs1m 31stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 51stez-tests in master has 6 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall0m 38sthe patch passed
+1 💚codespell0m 27sNo new issues.
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 19sthe patch passed
+1 💚javadoc0m 21sthe patch passed
+1 💚spotbugs1m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 33stez-common in the patch passed.
+1 💚unit40m 29stez-tests in the patch passed.
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
92m 30s
SubsystemReport/Notes
DockerClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/artifact/out/Dockerfile
GITHUB PR#439
Optional Testsdupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
unameLinux 466d5ef3ee01 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-439/src/.yetus/personality.sh
git revisionmaster / bb1bdee
Default JavaUbuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/testReport/
Max. process+thread count1038 (vs. ulimit of 5500)
modulesC: tez-common tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Path outputDir = Paths.get(ProfileServlet.OUTPUT_DIR).toAbsolutePath().normalize();
Path requestedPath = outputDir.resolve(queriedFile).normalize();

if (!requestedPath.startsWith(outputDir)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about an additional status here:

 response.setStatus(HttpServletResponse.SC_FORBIDDEN);

@abstractdog
abstractdog self-requested a review October 31, 2025 09:07

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep2m 3sMaven dependency ordering for branch
+1 💚mvninstall10m 10smaster passed
+1 💚compile1m 6smaster passed
+1 💚checkstyle1m 5smaster passed
+1 💚javadoc1m 1smaster passed
+0 🆗spotbugs1m 33stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 53stez-tests in master has 6 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall0m 39sthe patch passed
+1 💚codespell0m 27sNo new issues.
+1 💚compile0m 36sthe patch passed
+1 💚javac0m 36sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 17sthe patch passed
+1 💚javadoc0m 22sthe patch passed
+1 💚spotbugs1m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 34stez-common in the patch passed.
+1 💚unit41m 1stez-tests in the patch passed.
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
66m 12s
SubsystemReport/Notes
DockerClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/artifact/out/Dockerfile
GITHUB PR#439
Optional Testsdupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
unameLinux d68bdc0a5877 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-439/src/.yetus/personality.sh
git revisionmaster / b6ca7a8
Default JavaUbuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/testReport/
Max. process+thread count1037 (vs. ulimit of 5500)
modulesC: tez-common tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
ayushtkn merged commit 5775337 into apache:masterOct 31, 2025
4 checks passed
asf-gitbox-commits pushed a commit that referenced this pull request Jul 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog