TEZ-4654: Migrate from commons-lang2.x to commons-lang3.x by Aggarwal-Raghav · Pull Request #441 · apache/tez

Aggarwal-Raghav · 2025-11-12T10:48:03Z

Upgrade to commons-lang-3.19.0
org.apache.commons.lang.ArrayUtils => org.apache.commons.lang3.ArrayUtils
org.apache.commons.lang.RandomStringUtils => org.apache.commons.lang3.RandomStringUtils
org.apache.commons.lang.StringEscapeUtils => org.apache.commons.lang3.StringEscapeUtils
org.apache.commons.lang.StringUtils => org.apache.commons.lang3.StringUtils
org.apache.commons.lang.SystemUtils => org.apache.commons.lang3.SystemUtils
org.apache.commons.lang.exception.ExceptionUtils => org.apache.commons.lang3.exception.ExceptionUtils
org.apache.commons.lang.mutable.MutableInt => org.apache.commons.lang3.mutable.MutableInt
org.apache.commons.lang.NotImplementedException => org.apache.commons.lang3.NotImplementedException

Aggarwal-Raghav · 2025-11-12T11:04:59Z

Aggarwal-Raghav · 2025-11-12T16:34:16Z

Looks like UT failures are because of exclusion of common-lang 2.x in hadoop-yarn-server-tests jar. I have removed the exclusions. As the jar is in test scope dependency, we are only shipping commons-lang3.x.

From Hive perspective, commons-lang 2.x is part of hive-exec jar so, it shouldn't cause any runtime issues as well.

https://github.com/apache/hive/blob/c054a47c7c22875c93ca0d29b7ac730cf7deba04/ql/pom.xml#L1060

CC @abstractdog

abstractdog · 2025-12-02T16:44:07Z

@Aggarwal-Raghav : I can see only 1 problem in tez-javadoc-tools while compiling the java 17+ version

Aggarwal-Raghav · 2025-12-02T16:45:53Z

@Aggarwal-Raghav : I can see only 1 problem in tez-javadoc-tools while compiling the java 17+ version

@abstractdog , it is passing in local. Attaching the build logs for this module. Do i need to force push again?
tez-javadoc-buid.txt

Aggarwal-Raghav · 2025-12-02T17:06:59Z

Please suggest, what needs to be done.

abstractdog · 2026-01-22T11:29:00Z

Please suggest, what needs to be done.

sorry for the late reply, it has passed for me too locally, can you rebase and push to see it now? and then we'll decide

- Upgrade to commons-lang-3.19.0 - org.apache.commons.lang.ArrayUtils => org.apache.commons.lang3.ArrayUtils - org.apache.commons.lang.RandomStringUtils => org.apache.commons.lang3.RandomStringUtils - org.apache.commons.lang.StringEscapeUtils => org.apache.commons.lang3.StringEscapeUtils - org.apache.commons.lang.StringUtils => org.apache.commons.lang3.StringUtils - org.apache.commons.lang.SystemUtils => org.apache.commons.lang3.SystemUtils - org.apache.commons.lang.exception.ExceptionUtils => org.apache.commons.lang3.exception.ExceptionUtils - org.apache.commons.lang.mutable.MutableInt => org.apache.commons.lang3.mutable.MutableInt - org.apache.commons.lang.NotImplementedException => org.apache.commons.lang3.NotImplementedException

Aggarwal-Raghav · 2026-01-22T11:49:27Z

No Worries. Rebased

tez-yetus · 2026-01-22T15:23:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 12 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	2m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	9m 42s		master passed
+1 💚	compile	7m 7s		master passed
+1 💚	checkstyle	4m 41s		master passed
+1 💚	javadoc	5m 28s		master passed
-1 ❌	spotbugs	1m 17s	/branch-spotbugs-tez-api.txt	tez-api in master failed.
-1 ❌	spotbugs	0m 32s	/branch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in master failed.
-1 ❌	spotbugs	0m 37s	/branch-spotbugs-tez-runtime-library.txt	tez-runtime-library in master failed.
-1 ❌	spotbugs	0m 36s	/branch-spotbugs-tez-mapreduce.txt	tez-mapreduce in master failed.
-1 ❌	spotbugs	0m 44s	/branch-spotbugs-tez-dag.txt	tez-dag in master failed.
-1 ❌	spotbugs	0m 33s	/branch-spotbugs-tez-tests.txt	tez-tests in master failed.
-1 ❌	spotbugs	0m 32s	/branch-spotbugs-tez-plugins_tez-history-parser.txt	tez-history-parser in master failed.
-1 ❌	spotbugs	0m 26s	/branch-spotbugs-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in master failed.
-1 ❌	spotbugs	0m 21s	/branch-spotbugs-root.txt	root in master failed.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 20s	/patch-mvninstall-tez-tests.txt	tez-tests in the patch failed.
-1 ❌	mvninstall	0m 11s	/patch-mvninstall-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in the patch failed.
+1 💚	codespell	1m 36s		No new issues.
+1 💚	compile	7m 8s		the patch passed
+1 💚	javac	7m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 12s		the patch passed
+1 💚	javadoc	5m 20s		the patch passed
-1 ❌	spotbugs	0m 38s	/patch-spotbugs-tez-api.txt	tez-api in the patch failed.
-1 ❌	spotbugs	0m 33s	/patch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in the patch failed.
-1 ❌	spotbugs	0m 38s	/patch-spotbugs-tez-runtime-library.txt	tez-runtime-library in the patch failed.
-1 ❌	spotbugs	0m 34s	/patch-spotbugs-tez-mapreduce.txt	tez-mapreduce in the patch failed.
-1 ❌	spotbugs	0m 45s	/patch-spotbugs-tez-dag.txt	tez-dag in the patch failed.
-1 ❌	spotbugs	0m 35s	/patch-spotbugs-tez-tests.txt	tez-tests in the patch failed.
-1 ❌	spotbugs	0m 35s	/patch-spotbugs-tez-plugins_tez-history-parser.txt	tez-history-parser in the patch failed.
-1 ❌	spotbugs	0m 29s	/patch-spotbugs-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in the patch failed.
-1 ❌	spotbugs	0m 24s	/patch-spotbugs-root.txt	root in the patch failed.
			_ Other Tests _
+1 💚	unit	2m 36s		tez-api in the patch passed.
+1 💚	unit	1m 4s		tez-runtime-internals in the patch passed.
+1 💚	unit	6m 11s		tez-runtime-library in the patch passed.
+1 💚	unit	1m 36s		tez-mapreduce in the patch passed.
+1 💚	unit	6m 13s		tez-dag in the patch passed.
+1 💚	unit	41m 25s		tez-tests in the patch passed.
+1 💚	unit	2m 34s		tez-history-parser in the patch passed.
+1 💚	unit	0m 30s		tez-javadoc-tools in the patch passed.
+1 💚	unit	76m 28s		root in the patch passed.
+1 💚	asflicense	4m 4s		The patch does not generate ASF License warnings.
		213m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/3/artifact/out/Dockerfile
GITHUB PR	#441
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname	Linux 78db6b01deaa 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/src/.yetus/personality.sh
git revision	master / `c884d63`
Default Java	Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/3/testReport/
Max. process+thread count	2110 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-tests tez-plugins/tez-history-parser tez-tools/tez-javadoc-tools . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/3/console
versions	git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-01-22T15:40:44Z

looks good to me, spotbugs should be fixed though in TEZ-4669

abstractdog · 2026-01-22T15:41:15Z

looks good to me, spotbugs should be fixed though in TEZ-4669

I'll double-check the javadoc tools build, because it's weird...it compiles for me locally too

Aggarwal-Raghav · 2026-01-22T16:30:20Z

I'm speculating and might be wrong but is it possible that the -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0 is gone by the time this ran?

/patch-mvninstall-tez-tests.txt
/patch-mvninstall-tez-tools_tez-javadoc-tools.txt

WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-runtime-library:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-mapreduce:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

Aggarwal-Raghav · 2026-01-22T16:30:55Z

I'm speculating and might be wrong but is it possible that the -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0 is gone by the time this ran?

/patch-mvninstall-tez-tests.txt
/patch-mvninstall-tez-tools_tez-javadoc-tools.txt

WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-runtime-library:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-mapreduce:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

As its not able to find the previously build modules

abstractdog · 2026-01-22T16:57:53Z

I'm speculating and might be wrong but is it possible that the -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0 is gone by the time this ran?

/patch-mvninstall-tez-tests.txt
/patch-mvninstall-tez-tools_tez-javadoc-tools.txt

WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-runtime-library:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-mapreduce:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

As its not able to find the previously build modules

but right before these modules' build, there is e.g. tez-dag build as shown in
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/3/artifact/out/patch-mvninstall-tez-dag.txt

which ends with:

[INFO] Installing /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/src/tez-dag/target/tez-dag-1.0.0-SNAPSHOT.jar to /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0/org/apache/tez/tez-dag/1.0.0-SNAPSHOT/tez-dag-1.0.0-SNAPSHOT.jar

I cannot reproduce this locally now, and now it's not only tez-javadoc-tools but also tez-tests

more interestingly, tez-runtime-internals builds successfully, even though it's complaining about tez-api, which it depends on:
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/3/artifact/out/patch-mvninstall-tez-runtime-internals.txt

[WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

abstractdog · 2026-01-22T17:25:18Z

I just hacked yetus to add -X to maven command and explode, will see :)
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/4/console

tez-yetus · 2026-01-22T20:49:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 12 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	2m 30s		Maven dependency ordering for branch
+1 💚	mvninstall	9m 42s		master passed
+1 💚	compile	7m 11s		master passed
+1 💚	checkstyle	4m 41s		master passed
+1 💚	javadoc	5m 30s		master passed
-1 ❌	spotbugs	1m 18s	/branch-spotbugs-tez-api.txt	tez-api in master failed.
-1 ❌	spotbugs	0m 33s	/branch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in master failed.
-1 ❌	spotbugs	0m 37s	/branch-spotbugs-tez-runtime-library.txt	tez-runtime-library in master failed.
-1 ❌	spotbugs	0m 34s	/branch-spotbugs-tez-mapreduce.txt	tez-mapreduce in master failed.
-1 ❌	spotbugs	0m 45s	/branch-spotbugs-tez-dag.txt	tez-dag in master failed.
-1 ❌	spotbugs	0m 35s	/branch-spotbugs-tez-tests.txt	tez-tests in master failed.
-1 ❌	spotbugs	0m 35s	/branch-spotbugs-tez-plugins_tez-history-parser.txt	tez-history-parser in master failed.
-1 ❌	spotbugs	0m 29s	/branch-spotbugs-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in master failed.
-1 ❌	spotbugs	0m 24s	/branch-spotbugs-root.txt	root in master failed.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 22s	/patch-mvninstall-tez-tests.txt	tez-tests in the patch failed.
-1 ❌	mvninstall	0m 11s	/patch-mvninstall-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in the patch failed.
+1 💚	codespell	1m 37s		No new issues.
+1 💚	compile	7m 16s		the patch passed
+1 💚	javac	7m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 22s		the patch passed
+1 💚	javadoc	5m 23s		the patch passed
-1 ❌	spotbugs	0m 38s	/patch-spotbugs-tez-api.txt	tez-api in the patch failed.
-1 ❌	spotbugs	0m 33s	/patch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in the patch failed.
-1 ❌	spotbugs	0m 38s	/patch-spotbugs-tez-runtime-library.txt	tez-runtime-library in the patch failed.
-1 ❌	spotbugs	0m 36s	/patch-spotbugs-tez-mapreduce.txt	tez-mapreduce in the patch failed.
-1 ❌	spotbugs	0m 44s	/patch-spotbugs-tez-dag.txt	tez-dag in the patch failed.
-1 ❌	spotbugs	0m 36s	/patch-spotbugs-tez-tests.txt	tez-tests in the patch failed.
-1 ❌	spotbugs	0m 33s	/patch-spotbugs-tez-plugins_tez-history-parser.txt	tez-history-parser in the patch failed.
-1 ❌	spotbugs	0m 29s	/patch-spotbugs-tez-tools_tez-javadoc-tools.txt	tez-javadoc-tools in the patch failed.
-1 ❌	spotbugs	0m 25s	/patch-spotbugs-root.txt	root in the patch failed.
			_ Other Tests _
+1 💚	unit	2m 36s		tez-api in the patch passed.
+1 💚	unit	1m 4s		tez-runtime-internals in the patch passed.
+1 💚	unit	6m 15s		tez-runtime-library in the patch passed.
+1 💚	unit	1m 35s		tez-mapreduce in the patch passed.
+1 💚	unit	6m 8s		tez-dag in the patch passed.
+1 💚	unit	36m 57s		tez-tests in the patch passed.
+1 💚	unit	2m 35s		tez-history-parser in the patch passed.
+1 💚	unit	0m 30s		tez-javadoc-tools in the patch passed.
+1 💚	unit	74m 8s		root in the patch passed.
+1 💚	asflicense	4m 6s		The patch does not generate ASF License warnings.
		207m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/4/artifact/out/Dockerfile
GITHUB PR	#441
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname	Linux ce8e27e96d23 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/src/.yetus/personality.sh
git revision	master / `c884d63`
Default Java	Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/4/testReport/
Max. process+thread count	1399 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-tests tez-plugins/tez-history-parser tez-tools/tez-javadoc-tools . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/4/console
versions	git=2.43.0 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

maheshrajus · 2026-01-23T06:06:59Z

@Aggarwal-Raghav spotbugs report showing -1 for all modules. It is failed due to below error. Can you check it ?


1) null returned by binding at org.eclipse.sisu.wire.LocatorWiring
but the 1st parameter of org.codehaus.plexus.velocity.internal.DefaultVelocityComponent.<init>(Unknown Source) is not @Nullable
at org.eclipse.sisu.wire.LocatorWiring
while locating org.codehaus.plexus.velocity.VelocityComponentConfigurator
for the 1st parameter of org.codehaus.plexus.velocity.internal.DefaultVelocityComponent.<init>(Unknown Source)
at ClassRealm[plugin>com.github.spotbugs:spotbugs-maven-plugin:4.9.3.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@639fee48] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.codehaus.plexus.velocity.internal.DefaultVelocityComponent
while locating java.lang.Object annotated with *
at org.eclipse.sisu.wire.LocatorWiring
while locating org.codehaus.plexus.velocity.VelocityComponent
for field at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.velocity(Unknown Source)
at ClassRealm[plugin>com.github.spotbugs:spotbugs-maven-plugin:4.9.3.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@639fee48] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.doxia.siterenderer.DefaultSiteRenderer
while locating java.lang.Object annotated with *
while locating org.codehaus.mojo.spotbugs.SpotBugsMojo
1 error
at com.google.inject.internal.InternalProvisionException.toProvisionException (InternalProvisionException.java:226)
at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1097)
at com.google.inject.internal.InjectorImpl.getInstance (InjectorImpl.java:1131)
at org.eclipse.sisu.space.AbstractDeferredClass.get (AbstractDeferredClass.java:48)
at com.google.inject.internal.ProviderInternalFactory.provision (ProviderInternalFactory.java:85)
at com.google.inject.internal.InternalFactoryToInitializableAdapter.provision (InternalFactoryToInitializableAdapter.java:57)
at com.google.inject.internal.ProviderInternalFactory$1.call (ProviderInternalFactory.java:66)
at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision (ProvisionListenerStackCallback.java:112)
at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision (ProvisionListenerStackCallback.java:127)
at com.google.inject.internal.ProvisionListenerStackCallback.provision (ProvisionListenerStackCallback.java:66)
at com.google.inject.internal.ProviderInternalFactory.circularGet (ProviderInternalFactory.java:61)
at com.google.inject.internal.InternalFactoryToInitializableAdapter.get (InternalFactoryToInitializableAdapter.java:47)
at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1094)

abstractdog · 2026-01-23T08:22:23Z

@Aggarwal-Raghav spotbugs report showing -1 for all modules. It is failed due to below error. Can you check it ?


1) null returned by binding at org.eclipse.sisu.wire.LocatorWiring
but the 1st parameter of org.codehaus.plexus.velocity.internal.DefaultVelocityComponent.<init>(Unknown Source) is not @Nullable
at org.eclipse.sisu.wire.LocatorWiring
while locating org.codehaus.plexus.velocity.VelocityComponentConfigurator
for the 1st parameter of org.codehaus.plexus.velocity.internal.DefaultVelocityComponent.<init>(Unknown Source)
at ClassRealm[plugin>com.github.spotbugs:spotbugs-maven-plugin:4.9.3.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@639fee48] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.codehaus.plexus.velocity.internal.DefaultVelocityComponent
while locating java.lang.Object annotated with *
at org.eclipse.sisu.wire.LocatorWiring
while locating org.codehaus.plexus.velocity.VelocityComponent
for field at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.velocity(Unknown Source)
at ClassRealm[plugin>com.github.spotbugs:spotbugs-maven-plugin:4.9.3.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@639fee48] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
while locating org.apache.maven.doxia.siterenderer.DefaultSiteRenderer
while locating java.lang.Object annotated with *
while locating org.codehaus.mojo.spotbugs.SpotBugsMojo
1 error
at com.google.inject.internal.InternalProvisionException.toProvisionException (InternalProvisionException.java:226)
at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1097)
at com.google.inject.internal.InjectorImpl.getInstance (InjectorImpl.java:1131)
at org.eclipse.sisu.space.AbstractDeferredClass.get (AbstractDeferredClass.java:48)
at com.google.inject.internal.ProviderInternalFactory.provision (ProviderInternalFactory.java:85)
at com.google.inject.internal.InternalFactoryToInitializableAdapter.provision (InternalFactoryToInitializableAdapter.java:57)
at com.google.inject.internal.ProviderInternalFactory$1.call (ProviderInternalFactory.java:66)
at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision (ProvisionListenerStackCallback.java:112)
at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision (ProvisionListenerStackCallback.java:127)
at com.google.inject.internal.ProvisionListenerStackCallback.provision (ProvisionListenerStackCallback.java:66)
at com.google.inject.internal.ProviderInternalFactory.circularGet (ProviderInternalFactory.java:61)
at com.google.inject.internal.InternalFactoryToInitializableAdapter.get (InternalFactoryToInitializableAdapter.java:47)
at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1094)

already tracked on TEZ-4669

abstractdog · 2026-01-23T09:00:31Z

debug level maven logs revealed new exotic things:

[WARNING] Invalid POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT, transitive dependencies (if any) will not be available, enable debug logging for more details: Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.apache.commons:commons-lang3:jar is missing. @ line 106, column 17

so invalid POM is some missing version, but still don't get how could this come in precommit and not locally

abstractdog · 2026-01-23T09:41:27Z

reproduced the maven compile problem on an ubuntu server by hitting the same commands as yetus:

mvn clean
cd tez-api && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..
cd tez-dag && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..
cd tez-mapreduce && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..
cd tez-runtime-library && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..
cd tez-runtime-internals && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..
cd tez-tests && mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true && cd ..

again, the same didn't happen on my mac

Aggarwal-Raghav · 2026-01-23T09:46:56Z

I'll also look into this over the weekend.

Aggarwal-Raghav · 2026-01-23T10:06:37Z

Can we remove this cd and replace with -pland try once? I'm building that docker image in build-tools/docker but its taking time.

mvn clean install -pl tez-api,tez-dag,tez-mapreduce,tez-runtime-library,tez-runtime-internals,tez-tests \
-DskipTests \
-Dmaven.javadoc.skip=true \
-Dcheckstyle.skip=true \
-Dfindbugs.skip=true \
-Dspotbugs.skip=true

abstractdog · 2026-01-23T10:10:46Z

Can we remove this cd and replace with -pland try once? I'm building that docker image in build-tools/docker but its taking time.
mvn clean install -pl tez-api,tez-dag,tez-mapreduce,tez-runtime-library,tez-runtime-internals,tez-tests \
-DskipTests \
-Dmaven.javadoc.skip=true \
-Dcheckstyle.skip=true \
-Dfindbugs.skip=true \
-Dspotbugs.skip=true

I'm afraid we cannot, this is deep inside yetus logic, how it identifies the affected modules and their dependencies, and build them one by one

abstractdog · 2026-01-23T13:52:06Z

ignore my last comment about effective pom, it was wrong, deleted it

abstractdog · 2026-01-23T14:02:50Z

hm, strange, now I can repro the same locally too :D

mvn -version
Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29)
Maven home: /Users/lbodor/Applications/maven
Java version: 21.0.8, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-21.jdk/Contents/Home
Default locale: en_HU, platform encoding: UTF-8
OS name: "mac os x", version: "15.7.3", arch: "aarch64", family: "mac"
mvn clean
rm -rf ~/.m2/repository/org/apache/tez
cd tez-api && mvn clean install -DskipTests && cd ..
cd tez-runtime-internals && mvn clean install -DskipTests && cd ..
cd tez-runtime-library && mvn clean install -DskipTests && cd ..
cd tez-mapreduce && mvn clean install -DskipTests && cd ..
cd tez-dag && mvn clean install -DskipTests && cd ..
cd tez-tests && mvn clean install -DskipTests && cd ..

Aggarwal-Raghav · 2026-01-23T14:16:17Z

I'm also able to repro with the steps you have shared on mac but @abstractdog , isn't this way of doing things wrong? if clean the ~/.m2/repository cache and build the modules like tez-runtime-internals the depedent modules (tez-commons )etc. will be downloaded from snapshot artifactory.
We shouldn't delete the .m2 for this smart-apply-patch.sh

Aggarwal-Raghav · 2026-01-23T14:18:45Z

I'm speculating and might be wrong but is it possible that the -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0 is gone by the time this ran?

/patch-mvninstall-tez-tests.txt
/patch-mvninstall-tez-tools_tez-javadoc-tools.txt

WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-runtime-library:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-mapreduce:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

As its not able to find the previously build modules

That's what I was suspecting yesterday as well. Maybe I couldn't communicate it better.

abstractdog · 2026-01-23T16:54:07Z

I'm speculating and might be wrong but is it possible that the -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0 is gone by the time this ran?
/patch-mvninstall-tez-tests.txt
/patch-mvninstall-tez-tools_tez-javadoc-tools.txt
WARNING] The POM for org.apache.tez:tez-api:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-runtime-library:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-mapreduce:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for org.apache.tez:tez-dag:jar:1.0.0-SNAPSHOT is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
As its not able to find the previously build modules
That's what I was suspecting yesterday as well. Maybe I couldn't communicate it better.

I agree that building the project module by module is not necessarily the most optimal way, because we can figure out what went wrong even if the whole project is built in one go, I'm totally fine with a patch where the maven build phase is done in one go, and as a positive side effect, this issue would also go away

abstractdog · 2026-01-26T09:33:24Z

made a decision here, this PR should be merged, I'm not about to block valuable contributions because we cannot figure out and solve infra problems easily, so in this case:

spotbugs is broken: TEZ-4669
mvn install is broken if there is a new property in the root pom: TEZ-4684

this patch looks safe and clean

This comment was marked as outdated.
Sign in to view

Aggarwal-Raghav force-pushed the TEZ-4654 branch from 25ee1ed to cafecd5Compare November 12, 2025 16:29

This comment was marked as outdated.
Sign in to view

abstractdog self-requested a review January 22, 2026 11:15

Aggarwal-Raghav force-pushed the TEZ-4654 branch from cafecd5 to c884d63Compare January 22, 2026 11:49

abstractdog approved these changes Jan 26, 2026
View reviewed changes

abstractdog merged commit 1fc0035 into apache:masterJan 26, 2026
4 checks passed

Uh oh!

Conversation

Aggarwal-Raghav commented Nov 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Nov 12, 2025

Uh oh!

This comment was marked as outdated.

Aggarwal-Raghav commented Nov 12, 2025

Uh oh!

This comment was marked as outdated.

abstractdog commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Dec 2, 2025

Uh oh!

abstractdog commented Jan 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Jan 22, 2026

Uh oh!

tez-yetus commented Jan 22, 2026

Uh oh!

abstractdog commented Jan 22, 2026

Uh oh!

abstractdog commented Jan 22, 2026

Uh oh!

Aggarwal-Raghav commented Jan 22, 2026

Uh oh!

Aggarwal-Raghav commented Jan 22, 2026

Uh oh!

abstractdog commented Jan 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abstractdog commented Jan 22, 2026

Uh oh!

tez-yetus commented Jan 22, 2026

Uh oh!

maheshrajus commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abstractdog commented Jan 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Jan 23, 2026

Uh oh!

Aggarwal-Raghav commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Jan 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Jan 23, 2026

Uh oh!

abstractdog commented Jan 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abstractdog commented Jan 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Aggarwal-Raghav commented Nov 12, 2025•
edited
Loading

abstractdog commented Dec 2, 2025•
edited
Loading

Aggarwal-Raghav commented Dec 2, 2025•
edited
Loading

abstractdog commented Jan 22, 2026•
edited
Loading

abstractdog commented Jan 22, 2026•
edited
Loading

abstractdog commented Jan 23, 2026•
edited
Loading

abstractdog commented Jan 23, 2026•
edited
Loading

abstractdog commented Jan 23, 2026•
edited
Loading

Aggarwal-Raghav commented Jan 23, 2026•
edited
Loading

abstractdog commented Jan 23, 2026•
edited
Loading

abstractdog commented Jan 26, 2026•
edited
Loading