Skip to content

TEZ-4655: Upgrade Upgrade to netty 4.1.130.Final - #442

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4655
Jan 22, 2026
Merged

TEZ-4655: Upgrade Upgrade to netty 4.1.130.Final#442
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4655

Conversation

@Aggarwal-Raghav

@Aggarwal-RaghavAggarwal-Raghav commented Nov 12, 2025

Copy link
Copy Markdown
Contributor
  • Exclusion of netty dependency from hadoop-common test-jar dependency

Dependency Tree:
netty-changes-dependency-tree.txt

Screenshot 2026-01-22 at 5 45 29 PM

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec13m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall9m 44smaster passed
+1 💚compile1m 18smaster passed
+1 💚javadoc1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 38sthe patch passed
+1 💚codespell0m 28sNo new issues.
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit60m 14sroot in the patch passed.
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
92m 38s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/artifact/out/Dockerfile
GITHUB PR#442
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux 6707cee02c51 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-442/src/.yetus/personality.sh
git revisionmaster / 1e3ee2c
Default JavaUbuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/testReport/
Max. process+thread count1442 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/console
versionsgit=2.43.0 maven=3.8.7 codespell=2.0.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review November 12, 2025 14:22
Comment threadpom.xml
<artifactId>jersey-server</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclusion from test jar should be fine as its only minor version changes. Usually netty 4.1.x series is backward compatible.

@abstractdog

Copy link
Copy Markdown
Contributor

the latest on 4.1 line now is 4.1.130.Final, can you please check if it works too? if so, we can use it I believe

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

the latest on 4.1 line now is 4.1.130.Final, can you please check if it works too? if so, we can use it I believe

Checking. I'll try to run some sample query on hive master branch as well to do a sanity check with netty-4.1.130

- Exclusion of netty dependency from hadoop-common test-jar dependency
@Aggarwal-RaghavAggarwal-Raghav changed the title TEZ-4655: Upgrade Upgrade to netty 4.1.128.FinalTEZ-4655: Upgrade Upgrade to netty 4.1.130.FinalJan 22, 2026
@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Tested with hive as well (basic insert) without TEZ-4007 changes. With that it was stuck. Updated the PR descriptions as well

I have gone through that interesting feature (TEZ-4007) and have some excited questions about it, will ask them separately

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall9m 12smaster passed
+1 💚compile1m 25smaster passed
+1 💚javadoc1m 5smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 54sthe patch passed
+1 💚codespell0m 59sNo new issues.
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit59m 9sroot in the patch passed.
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
78m 43s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/artifact/out/Dockerfile
GITHUB PR#442
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux b7b2c5b0013b 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-442/src/.yetus/personality.sh
git revisionmaster / e04b68c
Default JavaUbuntu-21.0.9+10-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/testReport/
Max. process+thread count1374 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/console
versionsgit=2.43.0 maven=3.8.7 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review January 22, 2026 13:33
@abstractdog

abstractdog commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

precommit is green, this is ready to merge
fixing possible problems after TEZ-4007 is a different thing

@abstractdog
abstractdog merged commit ec3f0ef into apache:masterJan 22, 2026
4 checks passed
@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4655 branch January 24, 2026 20:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog