Skip to content

TEZ-4672: Spotless: cleanup and force removing trailing whitespaces - #450

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4672
Feb 24, 2026
Merged

TEZ-4672: Spotless: cleanup and force removing trailing whitespaces#450
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4672

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 14s#450 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/1/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

Changes LGTM +1, pending yetus checks

Ran the mvn spotless:apply after taking just the pom changes and the diff b/w commits are same

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 15s#450 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/2/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented Jan 26, 2026

Copy link
Copy Markdown
ContributorAuthor

fails due to Yetus limitations, now I'm retrying with @ayushtkn's wonderful workaround #423 (comment)

https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/

also, @ayushtkn if you have the chance to take a look at this change, I would appreciate, big thing, easy rules

 <trimTrailingWhitespace/>

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec5m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 3sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 91 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep2m 16sMaven dependency ordering for branch
+1 💚mvninstall7m 19smaster passed
+1 💚compile6m 14smaster passed
+1 💚checkstyle4m 35smaster passed
+1 💚javadoc4m 55smaster passed
-1 ❌spotbugs1m 1s/branch-spotbugs-tez-api.txttez-api in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-common.txttez-common in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-runtime-internals.txttez-runtime-internals in master failed.
-1 ❌spotbugs0m 21s/branch-spotbugs-tez-runtime-library.txttez-runtime-library in master failed.
-1 ❌spotbugs0m 19s/branch-spotbugs-tez-mapreduce.txttez-mapreduce in master failed.
-1 ❌spotbugs0m 18s/branch-spotbugs-tez-examples.txttez-examples in master failed.
-1 ❌spotbugs0m 26s/branch-spotbugs-tez-dag.txttez-dag in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-tests.txttez-tests in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-ext-service-tests.txttez-ext-service-tests in master failed.
-1 ❌spotbugs0m 23s/branch-spotbugs-tez-plugins_tez-yarn-timeline-history.txttez-yarn-timeline-history in master failed.
-1 ❌spotbugs0m 21s/branch-spotbugs-tez-plugins_tez-yarn-timeline-history-with-acls.txttez-yarn-timeline-history-with-acls in master failed.
-1 ❌spotbugs0m 19s/branch-spotbugs-tez-plugins_tez-history-parser.txttez-history-parser in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-plugins_tez-aux-services.txttez-aux-services in master failed.
-1 ❌spotbugs0m 12s/branch-spotbugs-root.txtroot in master failed.
-1 ❌spotbugs0m 20s/branch-spotbugs-tez-tools_analyzers_job-analyzer.txtjob-analyzer in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
+1 💚mvninstall6m 31sthe patch passed
+1 💚codespell0m 54sNo new issues.
+1 💚compile5m 37sthe patch passed
+1 💚javac5m 37sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 15s/results-checkstyle-tez-api.txttez-api: The patch generated 1 new + 553 unchanged - 1 fixed = 554 total (was 554)
-0 ⚠️checkstyle0m 10s/results-checkstyle-tez-common.txttez-common: The patch generated 2 new + 66 unchanged - 2 fixed = 68 total (was 68)
-0 ⚠️checkstyle0m 15s/results-checkstyle-tez-runtime-library.txttez-runtime-library: The patch generated 4 new + 689 unchanged - 4 fixed = 693 total (was 693)
-0 ⚠️checkstyle0m 13s/results-checkstyle-tez-mapreduce.txttez-mapreduce: The patch generated 62 new + 690 unchanged - 62 fixed = 752 total (was 752)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-dag.txttez-dag: The patch generated 16 new + 1830 unchanged - 16 fixed = 1846 total (was 1846)
-0 ⚠️checkstyle0m 14s/results-checkstyle-tez-tests.txttez-tests: The patch generated 6 new + 1042 unchanged - 7 fixed = 1048 total (was 1049)
-0 ⚠️checkstyle0m 11s/results-checkstyle-tez-ext-service-tests.txttez-ext-service-tests: The patch generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
-0 ⚠️checkstyle0m 42s/results-checkstyle-root.txtroot: The patch generated 92 new + 5263 unchanged - 93 fixed = 5355 total (was 5356)
+1 💚javadoc4m 14sthe patch passed
-1 ❌spotbugs0m 23s/patch-spotbugs-tez-api.txttez-api in the patch failed.
-1 ❌spotbugs0m 19s/patch-spotbugs-tez-common.txttez-common in the patch failed.
-1 ❌spotbugs0m 23s/patch-spotbugs-tez-runtime-internals.txttez-runtime-internals in the patch failed.
-1 ❌spotbugs0m 22s/patch-spotbugs-tez-runtime-library.txttez-runtime-library in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-mapreduce.txttez-mapreduce in the patch failed.
-1 ❌spotbugs0m 19s/patch-spotbugs-tez-examples.txttez-examples in the patch failed.
-1 ❌spotbugs0m 23s/patch-spotbugs-tez-dag.txttez-dag in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-tests.txttez-tests in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-ext-service-tests.txttez-ext-service-tests in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-plugins_tez-yarn-timeline-history.txttez-yarn-timeline-history in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-plugins_tez-yarn-timeline-history-with-acls.txttez-yarn-timeline-history-with-acls in the patch failed.
-1 ❌spotbugs0m 24s/patch-spotbugs-tez-plugins_tez-history-parser.txttez-history-parser in the patch failed.
-1 ❌spotbugs0m 20s/patch-spotbugs-tez-plugins_tez-aux-services.txttez-aux-services in the patch failed.
-1 ❌spotbugs0m 24s/patch-spotbugs-tez-tools_analyzers_job-analyzer.txtjob-analyzer in the patch failed.
-1 ❌spotbugs0m 15s/patch-spotbugs-root.txtroot in the patch failed.
_ Other Tests _
+1 💚unit2m 3stez-api in the patch passed.
+1 💚unit0m 29stez-common in the patch passed.
+1 💚unit0m 46stez-runtime-internals in the patch passed.
+1 💚unit4m 13stez-runtime-library in the patch passed.
+1 💚unit1m 3stez-mapreduce in the patch passed.
+1 💚unit0m 20stez-examples in the patch passed.
+1 💚unit5m 40stez-dag in the patch passed.
+1 💚unit34m 46stez-tests in the patch passed.
+1 💚unit3m 42stez-ext-service-tests in the patch passed.
+1 💚unit1m 30stez-yarn-timeline-history in the patch passed.
+1 💚unit1m 37stez-yarn-timeline-history-with-acls in the patch passed.
+1 💚unit2m 4stez-history-parser in the patch passed.
+1 💚unit2m 32stez-aux-services in the patch passed.
+1 💚unit2m 16sjob-analyzer in the patch passed.
+1 💚unit59m 44sroot in the patch passed.
+1 💚asflicense3m 48sThe patch does not generate ASF License warnings.
194m 8s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/artifact/out/Dockerfile
GITHUB PR#450
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
unameLinux ee29f201a231 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-450/src/.yetus/personality.sh
git revisionmaster / 8fd1676
Default JavaUbuntu-21.0.9+10-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/testReport/
Max. process+thread count1371 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/console
versionsgit=2.43.0 maven=3.8.7 codespell=2.4.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

spotbugs is broken as TEZ-4669, rest looks good to me
it's strange that so few checkstyle warnings have been solved, but I'm still confident this spotless rule made the code better

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec5m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 3sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 91 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep2m 20sMaven dependency ordering for branch
+1 💚mvninstall7m 13smaster passed
+1 💚compile6m 26smaster passed
+1 💚checkstyle5m 3smaster passed
+1 💚javadoc5m 8smaster passed
+0 🆗spotbugs1m 31stez-api in master has 545 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 34stez-runtime-internals in master has 111 extant spotbugs warnings.
+0 🆗spotbugs0m 42stez-runtime-library in master has 235 extant spotbugs warnings.
+0 🆗spotbugs0m 33stez-mapreduce in master has 124 extant spotbugs warnings.
+0 🆗spotbugs0m 26stez-examples in master has 2 extant spotbugs warnings.
+0 🆗spotbugs1m 1stez-dag in master has 749 extant spotbugs warnings.
+0 🆗spotbugs0m 33stez-tests in master has 6 extant spotbugs warnings.
+0 🆗spotbugs0m 32stez-ext-service-tests in master has 62 extant spotbugs warnings.
+0 🆗spotbugs0m 29stez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings.
+0 🆗spotbugs0m 30stez-plugins/tez-yarn-timeline-history-with-acls in master has 2 extant spotbugs warnings.
+0 🆗spotbugs0m 31stez-plugins/tez-history-parser in master has 21 extant spotbugs warnings.
+0 🆗spotbugs0m 30stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs4m 2sroot in master has 1935 extant spotbugs warnings.
+0 🆗spotbugs0m 30stez-tools/analyzers/job-analyzer in master has 20 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall6m 18sthe patch passed
+1 💚codespell0m 47sNo new issues.
+1 💚compile6m 35sthe patch passed
+1 💚javac6m 35sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 19s/results-checkstyle-tez-api.txttez-api: The patch generated 1 new + 551 unchanged - 1 fixed = 552 total (was 552)
-0 ⚠️checkstyle0m 15s/results-checkstyle-tez-common.txttez-common: The patch generated 2 new + 66 unchanged - 2 fixed = 68 total (was 68)
-0 ⚠️checkstyle0m 21s/results-checkstyle-tez-runtime-library.txttez-runtime-library: The patch generated 4 new + 688 unchanged - 4 fixed = 692 total (was 692)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-mapreduce.txttez-mapreduce: The patch generated 62 new + 687 unchanged - 62 fixed = 749 total (was 749)
-0 ⚠️checkstyle0m 26s/results-checkstyle-tez-dag.txttez-dag: The patch generated 16 new + 1829 unchanged - 16 fixed = 1845 total (was 1845)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-tests.txttez-tests: The patch generated 6 new + 1041 unchanged - 7 fixed = 1047 total (was 1048)
-0 ⚠️checkstyle0m 14s/results-checkstyle-tez-ext-service-tests.txttez-ext-service-tests: The patch generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
-0 ⚠️checkstyle0m 48s/results-checkstyle-root.txtroot: The patch generated 92 new + 5257 unchanged - 93 fixed = 5349 total (was 5350)
+1 💚javadoc4m 52sthe patch passed
+1 💚spotbugs14m 13sthe patch passed
_ Other Tests _
+1 💚unit2m 5stez-api in the patch passed.
+1 💚unit0m 31stez-common in the patch passed.
+1 💚unit0m 48stez-runtime-internals in the patch passed.
+1 💚unit4m 30stez-runtime-library in the patch passed.
+1 💚unit1m 4stez-mapreduce in the patch passed.
+1 💚unit0m 21stez-examples in the patch passed.
+1 💚unit5m 26stez-dag in the patch passed.
+1 💚unit34m 55stez-tests in the patch passed.
+1 💚unit3m 48stez-ext-service-tests in the patch passed.
+1 💚unit1m 33stez-yarn-timeline-history in the patch passed.
+1 💚unit1m 39stez-yarn-timeline-history-with-acls in the patch passed.
+1 💚unit2m 7stez-history-parser in the patch passed.
+1 💚unit2m 36stez-aux-services in the patch passed.
+1 💚unit2m 21sjob-analyzer in the patch passed.
+1 💚unit60m 10sroot in the patch passed.
+1 💚asflicense4m 22sThe patch does not generate ASF License warnings.
217m 59s
SubsystemReport/Notes
DockerClientAPI=1.53 ServerAPI=1.53 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/artifact/out/Dockerfile
GITHUB PR#450
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
unameLinux 98f56b03d2ca 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 21:35:19 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-450/src/.yetus/personality.sh
git revisionmaster / 1d8b852
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/testReport/
Max. process+thread count2105 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

checkstyle seems to be clean (or at least there is equal or less warnings)
@ayushtkn : could you please review?

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
abstractdog merged commit e4ee751 into apache:masterFeb 24, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@tez-yetus@Aggarwal-Raghav@ayushtkn