Uh oh!
There was an error while loading. Please reload this page.
TEZ-4682: [Cloud] Tez AM docker image - #456
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@abstractdog , I was able to start DagAppMaster with ZK on local. Attaching logs for the container docker_logs.txt But this PR has lot of open items and I need some advice on the following:
|
ffceca5 to
856875aCompare
This comment was marked as outdated.
This comment was marked as outdated.
very good, very good, let me check this in detail sometime this week, here are some pointers in the meantime, responding your questions:
there is no Yarn NodeManager in a k8s environment, so the reader of the entrypoint.sh should see a clear code distinguishing between needed env vars and legacy/backward-compatible env vars, that's what should be handled with care in my opinion
|
Thanks for the pointers @abstractdog .
Few additional things:
|
856875a to
bfebf9eCompare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c371557 to
9efce66CompareAggarwal-Raghav
commented
Feb 12, 2026
Using tez.local.mode=true, solves this as it will use |
This comment was marked as outdated.
This comment was marked as outdated.
9efce66 to
551075bCompare
This comment was marked as outdated.
This comment was marked as outdated.
Aggarwal-Raghav
commented
Feb 18, 2026
@abstractdog , Can you please help with review? |
abstractdog
commented
Feb 20, 2026
let me get back to this next week |
Aggarwal-Raghav
commented
Feb 20, 2026
sure |
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| mvn clean install -DskipTests -Pdocker,tools | ||
| ``` | ||
| 2. Install zookeeper in mac by: |
There was a problem hiding this comment.
can you add ubuntu steps? we might be so kind to let linux users' life be easier
There was a problem hiding this comment.
UPDATE: can we use a dockerized zookeeper instead? install ZK on the host machine looks against this whole cloud/docker initiative (also, in case of problems or ZK nodes messed up, deleting and restarting a container feels easier and cleaner to me)
Uh oh!
There was an error while loading. Please reload this page.
| # Tez AM Container Environment Configuration | ||
| HADOOP_USER_NAME=tez |
There was a problem hiding this comment.
nitpicking, can you order the env vars here the same as they are ordered in the entrypoint script?
| <argument>${project.basedir}/src/docker/build-docker.sh</argument> | ||
| <argument>-hadoop</argument> | ||
| <argument>${hadoop.version}</argument> | ||
| <argument>-tez</argument> | ||
| <argument>${project.version}</argument> | ||
| <argument>-repo</argument> | ||
| <argument>apache</argument> |
There was a problem hiding this comment.
can you make it similar to what I can see in Hive? much less verbose, e.g.
<arguments>
<argument>.... .sh</argument>
<argument>-hadoop ${hadoop.version}</argument>
<argument>-tez ${tez.version}</argument>
</arguments>
Aggarwal-Raghav
commented
Feb 25, 2026
Thanks for the thorough review @abstractdog . I'll address the review comments shortly, you can continue the review in the meantime. I hope you are able to build the image and start tez am standalone process 😅 I still believe we can get rid of hadoop tarball dependency completely as the hadoop dependent required jars are already part of tez tarball. It might unnecessary increase docker image size. Also please suggest should I use eclipse-temurin:21.0.3_9-jre-ubi9-minimal or jdk, in case we want to take jstack or other java debugging tools, jkd image is required. |
|
| # HADOOP FETCH LOGIC # | ||
| ###################### | ||
| HADOOP_FILE_NAME="hadoop-$HADOOP_VERSION.tar.gz" | ||
| HADOOP_URL=${HADOOP_URL:-"https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/$HADOOP_FILE_NAME"} |
There was a problem hiding this comment.
what about using this first:https://dlcdn.apache.org/hadoop/common/hadoop-3.4.2/hadoop-3.4.2.tar.gz
and then fall back to archive
archive.apache.org is crazy slow for me at the moment (not the first time), maybe it would worth discovering dlcdn.apache.org
| USER=tez | ||
| HADOOP_USER_NAME=tez |
There was a problem hiding this comment.
I can see finally DAGAppMaster is started as:
-Duser.name="$HADOOP_USER_NAME" \
do we need a separate HADOOP_USER_NAME env var?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thanks @Aggarwal-Raghav , this is so close, left minor comments
other than that, this is in a very good shape and I feel it's good to go in, we can fix anything later that might come along the way |
Aggarwal-Raghav
commented
Mar 17, 2026
|
abstractdog
commented
Mar 17, 2026
|
This comment was marked as outdated.
This comment was marked as outdated.
Aggarwal-Raghav
commented
Mar 23, 2026
@abstractdog , any input on this? |
tez-yetus
commented
Mar 23, 2026
💔 -1 overall
This message was automatically generated. |
abstractdog
commented
Mar 23, 2026
looks good @Aggarwal-Raghav : the NPE is because the example program uses in the long run we can make other than that, left minor comments regarding the example program |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| import org.slf4j.LoggerFactory; | ||
| /** | ||
| * Sample Program inspired for WordCount but to run with External Tez AM with Zookeeper. |
Aggarwal-Raghav
commented
Mar 23, 2026
Thanks for the suggestions. I'll address these today only. |
Hopefully have addressed all the review comments and added a log4j.properties in tez-examples jar. |
tez-yetus
commented
Mar 23, 2026
💔 -1 overall
This message was automatically generated. |
abstractdog
commented
Mar 24, 2026
@Aggarwal-Raghav, this is awesome, I just validated the patch with these steps: I believe this patch is finally ready to go in |
Uh oh!
There was an error while loading. Please reload this page.




No description provided.