Skip to content

TEZ-4694 Add package-level Javadoc descriptions so generated API docs show a short summary for each package - #466

Merged
abstractdog merged 2 commits into
apache:masterfrom
lewismc:TEZ-4694
Mar 19, 2026
Merged

TEZ-4694 Add package-level Javadoc descriptions so generated API docs show a short summary for each package#466
abstractdog merged 2 commits into
apache:masterfrom
lewismc:TEZ-4694

Conversation

@lewismc

@lewismclewismc commented Mar 16, 2026

Copy link
Copy Markdown
Member

PR for TEZ-4694
Although this is a large PR is is fairly trivial.

Package-level Javadoc

  • Added short package descriptions to existing package-info.java files across tez-api, tez-common, tez-dag, tez-mapreduce, tez-runtime-library, and tez-javadoc-tools.
  • Introduced package-info.java for API packages that had none.

Javadoc

  • Fixed Javadoc warnings by escaping HTML in comments (e.g. &, <, <=) in tez-api, tez-runtime-library, and tez-mapreduce.

Build

  • Registered generated-sources (e.g. protobuf output) as compile source roots via build-helper-maven-plugin in tez-mapreduce, tez-runtime-library, tez-runtime-internals, and tez-dag.
  • Enabled forked compiler with increased memory for tez-mapreduce, tez-runtime-internals, and tez-dag to avoid missing .class file errors during test-compile.

Please check that the package visibility assignments are correct. Thank you for any review.

Regarding the test4tests -1 Vote I suppose we could add a plugin to Yetus which ensures a description exists for each package-info.java however I think this is overkill.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec3m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep2m 11sMaven dependency ordering for branch
+1 💚mvninstall6m 56smaster passed
+1 💚compile4m 3smaster passed
+1 💚checkstyle3m 17smaster passed
+1 💚javadoc3m 16smaster passed
+0 🆗spotbugs1m 11stez-api in master has 545 extant spotbugs warnings.
+0 🆗spotbugs0m 31stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 32stez-runtime-internals in master has 111 extant spotbugs warnings.
+0 🆗spotbugs0m 41stez-runtime-library in master has 235 extant spotbugs warnings.
+0 🆗spotbugs0m 35stez-mapreduce in master has 124 extant spotbugs warnings.
+0 🆗spotbugs0m 56stez-dag in master has 749 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-tools/tez-javadoc-tools in master has 3 extant spotbugs warnings.
+0 🆗spotbugs4m 2sroot in master has 1935 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 41sthe patch passed
+1 💚codespell0m 48sNo new issues.
+1 💚compile4m 32sthe patch passed
+1 💚javac4m 32sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle2m 40sthe patch passed
+1 💚javadoc0m 37stez-api generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
+1 💚javadoc0m 17stez-common in the patch passed.
+1 💚javadoc0m 15stez-runtime-internals in the patch passed.
+1 💚javadoc0m 22stez-runtime-library generated 0 new + 0 unchanged - 8 fixed = 0 total (was 8)
+1 💚javadoc0m 21stez-mapreduce generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚javadoc0m 17stez-dag in the patch passed.
+1 💚javadoc0m 15stez-javadoc-tools in the patch passed.
+1 💚javadoc0m 51sroot generated 0 new + 0 unchanged - 19 fixed = 0 total (was 19)
+1 💚spotbugs10m 10sthe patch passed
_ Other Tests _
+1 💚unit2m 8stez-api in the patch passed.
+1 💚unit0m 31stez-common in the patch passed.
+1 💚unit0m 49stez-runtime-internals in the patch passed.
+1 💚unit4m 31stez-runtime-library in the patch passed.
+1 💚unit1m 7stez-mapreduce in the patch passed.
+1 💚unit5m 4stez-dag in the patch passed.
+1 💚unit0m 19stez-javadoc-tools in the patch passed.
+1 💚unit60m 39sroot in the patch passed.
+1 💚asflicense2m 23sThe patch does not generate ASF License warnings.
140m 5s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/1/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
unameLinux 3a107fcff3c4 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-466/src/.yetus/personality.sh
git revisionmaster / 1e51e7d
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/1/testReport/
Max. process+thread count2109 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-javadoc-tools . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/1/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Comment threadtez-mapreduce/pom.xml Outdated
@abstractdog

Copy link
Copy Markdown
Contributor

@lewismc : this is huge, thanks! left 2 minor comments

@lewismc

Copy link
Copy Markdown
MemberAuthor

Thanks for the review @abstractdog I made the changes.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec4m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep2m 13sMaven dependency ordering for branch
+1 💚mvninstall7m 11smaster passed
+1 💚compile4m 1smaster passed
+1 💚checkstyle3m 16smaster passed
+1 💚javadoc3m 18smaster passed
+0 🆗spotbugs1m 12stez-api in master has 545 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 34stez-runtime-internals in master has 111 extant spotbugs warnings.
+0 🆗spotbugs0m 44stez-runtime-library in master has 235 extant spotbugs warnings.
+0 🆗spotbugs0m 34stez-mapreduce in master has 124 extant spotbugs warnings.
+0 🆗spotbugs1m 1stez-dag in master has 749 extant spotbugs warnings.
+0 🆗spotbugs0m 26stez-tools/tez-javadoc-tools in master has 3 extant spotbugs warnings.
+0 🆗spotbugs3m 57sroot in master has 1935 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚codespell0m 48sNo new issues.
+1 💚compile3m 51sthe patch passed
+1 💚javac3m 51sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle2m 42sthe patch passed
+1 💚javadoc0m 36stez-api generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
+1 💚javadoc0m 18stez-common in the patch passed.
+1 💚javadoc0m 16stez-runtime-internals in the patch passed.
+1 💚javadoc0m 21stez-runtime-library generated 0 new + 0 unchanged - 8 fixed = 0 total (was 8)
+1 💚javadoc0m 21stez-mapreduce generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚javadoc0m 18stez-dag in the patch passed.
+1 💚javadoc0m 16stez-javadoc-tools in the patch passed.
+1 💚javadoc0m 51sroot generated 0 new + 0 unchanged - 19 fixed = 0 total (was 19)
+1 💚spotbugs9m 53sthe patch passed
_ Other Tests _
+1 💚unit2m 4stez-api in the patch passed.
+1 💚unit0m 31stez-common in the patch passed.
+1 💚unit0m 46stez-runtime-internals in the patch passed.
+1 💚unit4m 29stez-runtime-library in the patch passed.
+1 💚unit1m 6stez-mapreduce in the patch passed.
+1 💚unit5m 2stez-dag in the patch passed.
+1 💚unit0m 17stez-javadoc-tools in the patch passed.
+1 💚unit60m 18sroot in the patch passed.
+1 💚asflicense2m 25sThe patch does not generate ASF License warnings.
138m 52s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/2/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
unameLinux 66bc5a565493 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-466/src/.yetus/personality.sh
git revisionmaster / c99e386
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/2/testReport/
Max. process+thread count1355 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-javadoc-tools . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-466/2/console
versionsgit=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review March 19, 2026 06:38

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
abstractdog merged commit d2cfd25 into apache:masterMar 19, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lewismc@tez-yetus@abstractdog