Skip to content

TEZ-4693: Addendum: Default empty argLine to prevent Surefire crashes when the 'jacoco' profile is inactive - #470

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4693_add
Mar 23, 2026
Merged

TEZ-4693: Addendum: Default empty argLine to prevent Surefire crashes when the 'jacoco' profile is inactive#470
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4693_add

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

No description provided.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec7m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall7m 6smaster passed
+1 💚compile2m 21smaster passed
+1 💚javadoc1m 30smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 23sthe patch passed
+1 💚codespell1m 36sNo new issues.
+1 💚compile2m 18sthe patch passed
+1 💚javac2m 18sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit73m 56sroot in the patch passed.
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
103m 57s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/1/artifact/out/Dockerfile
GITHUB PR#470
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux 01b862aaad36 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-470/src/.yetus/personality.sh
git revisionmaster / 5eca63a
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/1/testReport/
Max. process+thread count1315 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/1/console
versionsgit=2.43.0 maven=3.8.7 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec14m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall7m 1smaster passed
+1 💚compile2m 28smaster passed
+1 💚javadoc1m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 45sthe patch passed
+1 💚codespell1m 50sNo new issues.
+1 💚compile2m 24sthe patch passed
+1 💚javac2m 24sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc1m 19sthe patch passed
_ Other Tests _
+1 💚unit71m 49sroot in the patch passed.
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
109m 46s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/2/artifact/out/Dockerfile
GITHUB PR#470
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux e849cbccb24f 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-470/src/.yetus/personality.sh
git revisionmaster / d121c35
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/2/testReport/
Max. process+thread count2094 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-470/2/console
versionsgit=2.43.0 maven=3.8.7 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

The UT for https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-468/3/Yetus_20Report/ has passed which were previously failing

@abstractdog
abstractdog self-requested a review March 22, 2026 09:00

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'm a bit confused how we didn't catch this :D anyway, tried now, it works locally

in the PR which introduced jacoco, unit test took only 2 min, but passed...

10:09:03 | +1 | unit | 2m 17s | root in the patch passed. 

@abstractdog
abstractdog merged commit 81cb670 into apache:masterMar 23, 2026
10 of 16 checks passed
@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4693_add branch May 1, 2026 05:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog