Skip to content

TEZ-4706: Use project build directory for Graphviz output and update documentation - #480

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4706
Apr 28, 2026
Merged

TEZ-4706: Use project build directory for Graphviz output and update documentation#480
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4706

Conversation

@Aggarwal-Raghav

@Aggarwal-RaghavAggarwal-Raghav commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Presently, Tez.gv (tez-dag/pom.xml) is created in project root directory. As the Visualize profile is specific to tez-dag, its better to move the Tez.gv in tez-dag/target/ directory.

@Aggarwal-Raghav

Aggarwal-Raghav commented Apr 14, 2026

Copy link
Copy Markdown
ContributorAuthor

@abstractdog , i think its better to move to
<tez.graphviz.output.file>Tez.gv</tez.graphviz.output.file> => <tez.graphviz.output.file>${project.build.directory}/Tez.gv</tez.graphviz.output.file>

it will generate in tez-dag/target/Tez.gv ?

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚codespell0m 7sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
1m 15s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/1/artifact/out/Dockerfile
GITHUB PR#480
Optional Testsdupname asflicense codespell detsecrets
unameLinux dff5152267bd 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-480/src/.yetus/personality.sh
git revisionmaster / 53f9a6a
Max. process+thread count56 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/1/console
versionsgit=2.43.0 maven=3.9.14 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

@abstractdog , i think its better to move to <tez.graphviz.output.file>Tez.gv</tez.graphviz.output.file> => <tez.graphviz.output.file>${project.build.directory}/Tez.gv</tez.graphviz.output.file>

it will generate in tez-dag/target/Tez.gv ?

even better, thanks! feel free to rename ticket/PR accordingly

also, don't forget to add this detail in the other ongoing PR:

* `-Dtez.graphviz.output.file` (Default: Tez.gv)

#477
because the default will become target/Tez.gv in this case

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

can you please review #477 then post that I'll update this, I don't wanna update BUILDING.txt in this PR or it will be like half-work in this pr (pom changes) and other half changes in 477 (REAME.md) changes.

@Aggarwal-RaghavAggarwal-Raghav changed the title TEZ-4706: Consider adding Tez.gv or *.gv to gitignoreTEZ-4706: Use project build directory for Graphviz output and update documentationApr 14, 2026
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec7m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall4m 19smaster passed
+1 💚compile2m 34smaster passed
+1 💚javadoc2m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall4m 1sthe patch passed
+1 💚codespell1m 36sNo new issues.
+1 💚compile2m 32sthe patch passed
+1 💚javac2m 32sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚markdownlint0m 2sNo new issues.
+1 💚javadoc1m 57sthe patch passed
_ Other Tests _
+1 💚unit5m 37stez-dag in the patch passed.
+1 💚unit70m 57sroot in the patch passed.
+1 💚asflicense1m 24sThe patch does not generate ASF License warnings.
107m 2s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/artifact/out/Dockerfile
GITHUB PR#480
Optional Testsdupname asflicense codespell detsecrets markdownlint javac javadoc unit xmllint compile
unameLinux 837daa0f75e2 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-480/src/.yetus/personality.sh
git revisionmaster / b1d9b94
Default JavaUbuntu-21.0.10+7-Ubuntu-124.04
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/testReport/
Max. process+thread count1354 (vs. ulimit of 5500)
modulesC: tez-dag . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/console
versionsgit=2.43.0 maven=3.9.14 codespell=2.4.1 markdownlint=0.46.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit 3caa7b2 into apache:masterApr 28, 2026
4 checks passed
@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4706 branch April 28, 2026 19:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog