TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez by Aggarwal-Raghav · Pull Request #481 · apache/tez

Aggarwal-Raghav · 2026-04-14T15:25:15Z

No description provided.

Aggarwal-Raghav · 2026-04-14T15:26:12Z

 JIRA_COMMENT="$JIRA_COMMENT

- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.


Used reference for color from yetus project.
https://github.com/apache/yetus/blob/45b8e4bbb994045f1d7d78a76d556e93f4faf3ed/precommit/src/main/shell/plugins.d/jira.sh#L494

where can I see the effect of this change?

i guess no where 😬, only github emoji by yetus are coming.

on JIRA also, no color and in github also no orange color. But i think its better to keep it orange. WDYT?

okay, we can consider removing test-patch.sh later if it turns out we don't use it at all

hmm,
Here is the scenario i'm thinking:
If in a PR new tests are added:
UT passed (unit): +1 green
UT failed (unit): -1 red
test4testsL +1 green
If no new UT were added:
test4tests): -0 orange irrespective of UT failure as they are handled be unit
I'm little confused. let me test few things.

tez-yetus · 2026-04-14T15:52:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	5m 2s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
			_ Patch Compile Tests _
+1 💚	codespell	0m 5s		No new issues.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 2s		No new issues.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		5m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/1/artifact/out/Dockerfile
GITHUB PR	#481
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs
uname	Linux 344de02a5d04 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh
git revision	master / `573c3bb`
Max. process+thread count	51 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/1/console
versions	git=2.43.0 maven=3.9.14 codespell=2.4.1 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Aggarwal-Raghav · 2026-04-14T15:54:24Z

I'll make 1 checkstyle fix i.e. java change to trigger the test4tests

tez-yetus · 2026-04-14T17:30:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		master passed
+1 💚	compile	1m 29s		master passed
+1 💚	checkstyle	1m 4s		master passed
+1 💚	javadoc	1m 12s		master passed
+0 🆗	spotbugs	0m 59s		tez-dag in master has 749 extant spotbugs warnings.
+0 🆗	spotbugs	3m 54s		root in master has 1935 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 5s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s		the patch passed
+1 💚	codespell	1m 0s		No new issues.
+1 💚	compile	1m 38s		the patch passed
+1 💚	javac	1m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 25s		tez-dag: The patch generated 0 new + 111 unchanged - 2 fixed = 111 total (was 113)
+1 💚	checkstyle	0m 35s		root: The patch generated 0 new + 111 unchanged - 2 fixed = 111 total (was 113)
+1 💚	shellcheck	0m 2s		No new issues.
+1 💚	javadoc	1m 18s		the patch passed
+1 💚	spotbugs	5m 13s		the patch passed
			_ Other Tests _
+1 💚	unit	4m 50s		tez-dag in the patch passed.
+1 💚	unit	59m 48s		root in the patch passed.
+1 💚	asflicense	0m 52s		The patch does not generate ASF License warnings.
		92m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/artifact/out/Dockerfile
GITHUB PR	#481
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs javac javadoc unit spotbugs checkstyle compile
uname	Linux 11f22fb961e3 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh
git revision	master / `035e159`
Default Java	Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/testReport/
Max. process+thread count	1336 (vs. ulimit of 5500)
modules	C: tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/console
versions	git=2.43.0 maven=3.9.14 spotbugs=4.9.3 codespell=2.4.1 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-04-15T09:03:15Z

 public DAGStatusBuilder getDAGStatus(Set<StatusGetOpts> statusOptions,
 long timeoutMillis) throws TezException {
- long timeoutNanos = timeoutMillis * 1000l * 1000l;
+ long timeoutNanos = timeoutMillis * 1000L * 1000L;


I think you can revert this when the patch is fully finalized and approved

tez-yetus · 2026-04-15T13:41:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s		master passed
+1 💚	compile	1m 35s		master passed
+1 💚	checkstyle	1m 2s		master passed
+1 💚	javadoc	1m 26s		master passed
+0 🆗	spotbugs	0m 53s		tez-api in master has 545 extant spotbugs warnings.
+0 🆗	spotbugs	3m 50s		root in master has 1935 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 6s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s		the patch passed
+1 💚	codespell	0m 48s		No new issues.
+1 💚	compile	1m 32s		the patch passed
+1 💚	javac	1m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	shellcheck	0m 2s		No new issues.
+1 💚	javadoc	1m 14s		the patch passed
+1 💚	spotbugs	5m 0s		the patch passed
			_ Other Tests _
-1 ❌	unit	1m 59s	/patch-unit-tez-api.txt	tez-api in the patch passed.
-1 ❌	unit	61m 52s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		90m 52s

Reason	Tests
Failed junit tests	tez.common.TestTezCommonUtils
	tez.common.TestTezCommonUtils

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/artifact/out/Dockerfile
GITHUB PR	#481
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs javac javadoc unit spotbugs checkstyle compile
uname	Linux 20f709d1daeb 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh
git revision	master / `462e10e`
Default Java	Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/testReport/
Max. process+thread count	1348 (vs. ulimit of 5500)
modules	C: tez-api . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/console
versions	git=2.43.0 maven=3.9.14 spotbugs=4.9.3 codespell=2.4.1 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

tez-yetus · 2026-04-15T14:30:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
			_ Patch Compile Tests _
+1 💚	codespell	0m 6s		No new issues.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		0m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/4/artifact/out/Dockerfile
GITHUB PR	#481
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs
uname	Linux 12a60895c737 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh
git revision	master / `faf4957`
Max. process+thread count	57 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/4/console
versions	git=2.43.0 maven=3.9.14 codespell=2.4.1 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Aggarwal-Raghav · 2026-04-28T13:51:33Z

i'll rebase and force push

abstractdog · 2026-04-28T13:52:54Z

i'll rebase and force push

thanks, feel free to rebase anything which was blocked on github actions issue and I'll check them again as soon as I can! 🚀

ayushtkn

What is the motivation behind this?

This has been discussed in hadoop as well & blocked every time:
apache/hadoop#6937 (comment)

The ticket mentioned in the Jira

This is the same as HADOOP-16611 but for Tez

This is also resolved as Not a Problem
The PR linked was also abandoned:
apache/hadoop#1523 (comment)

Aggarwal-Raghav · 2026-04-28T14:28:38Z

What is the motivation behind this?
This has been discussed in hadoop as well & blocked every time: apache/hadoop#6937 (comment)
The ticket mentioned in the Jira
This is the same as HADOOP-16611 but for Tez
This is also resolved as Not a Problem The PR linked was also abandoned: apache/hadoop#1523 (comment)

@ayushtkn , for changes in README, pom, Jenkinsfile or Dockerfile, it doesn't contains UT and it give -1 as overall yetus outcome.
One can argue for Java changes if no UT is there then -1 is correct behaviour but I don't see any file extension based decision making in yetus.

In build-tools/test-patch.sh checkTests(), the behaviour is if "documentation" keyword is present in PR title then it will not give -1 (I've not tested this behaviour)

 testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch`
echo "There appear to be $testReferences test files referenced in the patch."
if [[ $testReferences == 0 ]] ; then
if [[ $JENKINS == "true" ]] ; then
patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
if [[ $patchIsDoc != 0 ]] ; then
echo "The patch appears to be a documentation patch that doesn't require tests."
JIRA_COMMENT="$JIRA_COMMENT
{color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests."
return 0
fi
fi
JIRA_COMMENT="$JIRA_COMMENT

All in all its a PMC's decision what behaviour is more favourable for the project in long run . Please discuss among yourselves and let me know if I need to close this PR.

tez-yetus · 2026-04-28T17:14:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	8m 40s		Docker failed to build run-specific yetus/tez:tp-11071}.

Subsystem	Report/Notes
GITHUB PR	#481
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/5/console
versions	git=2.34.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-05-02T05:51:06Z

What is the motivation behind this?
This has been discussed in hadoop as well & blocked every time: apache/hadoop#6937 (comment)
The ticket mentioned in the Jira
This is the same as HADOOP-16611 but for Tez
This is also resolved as Not a Problem The PR linked was also abandoned: apache/hadoop#1523 (comment)
@ayushtkn , for changes in README, pom, Jenkinsfile or Dockerfile, it doesn't contains UT and it give -1 as overall yetus outcome. One can argue for Java changes if no UT is there then -1 is correct behaviour but I don't see any file extension based decision making in yetus.
In build-tools/test-patch.sh checkTests(), the behaviour is if "documentation" keyword is present in PR title then it will not give -1 (I've not tested this behaviour)
 testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch`
echo "There appear to be $testReferences test files referenced in the patch."
if [[ $testReferences == 0 ]] ; then
if [[ $JENKINS == "true" ]] ; then
patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
if [[ $patchIsDoc != 0 ]] ; then
echo "The patch appears to be a documentation patch that doesn't require tests."
JIRA_COMMENT="$JIRA_COMMENT
{color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests."
return 0
fi
fi
JIRA_COMMENT="$JIRA_COMMENT
All in all its a PMC's decision what behaviour is more favourable for the project in long run . Please discuss among yourselves and let me know if I need to close this PR.

no strong opinions about this, ultimately it's about the confetti_ball vs. broken_heart icon on top of the yetus report, but it doesn't break the pipeline, and lets the reviewer decide whether the patch is correct and merge, I'm fine with keeping as is

Aggarwal-Raghav · 2026-05-02T19:50:11Z

ok, closing this PR then

Aggarwal-Raghav commented Apr 14, 2026
View reviewed changes

abstractdog reviewed Apr 15, 2026
View reviewed changes

Aggarwal-Raghav force-pushed the TEZ-4705 branch from 035e159 to 462e10eCompare April 15, 2026 12:10

Aggarwal-Raghav force-pushed the TEZ-4705 branch from 462e10e to faf4957Compare April 15, 2026 14:29

abstractdog self-requested a review April 28, 2026 13:29

abstractdog approved these changes Apr 28, 2026
View reviewed changes

TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez
ef9d479

Aggarwal-Raghav force-pushed the TEZ-4705 branch from faf4957 to ef9d479Compare April 28, 2026 13:53

ayushtkn requested changes Apr 28, 2026
View reviewed changes

Aggarwal-Raghav closed this May 2, 2026

Uh oh!

Conversation

Aggarwal-Raghav commented Apr 14, 2026

Uh oh!

Aggarwal-RaghavApr 14, 2026

Choose a reason for hiding this comment

Uh oh!

abstractdogApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Aggarwal-RaghavApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Aggarwal-RaghavApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

abstractdogApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Aggarwal-RaghavApr 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tez-yetus commented Apr 14, 2026

Uh oh!

Aggarwal-Raghav commented Apr 14, 2026

Uh oh!

tez-yetus commented Apr 14, 2026

Uh oh!

abstractdogApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Aggarwal-RaghavApr 15, 2026

Choose a reason for hiding this comment

Uh oh!

tez-yetus commented Apr 15, 2026

Uh oh!

tez-yetus commented Apr 15, 2026

Uh oh!

Aggarwal-Raghav commented Apr 28, 2026

Uh oh!

abstractdog commented Apr 28, 2026

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

Aggarwal-Raghav commented Apr 28, 2026

Uh oh!

tez-yetus commented Apr 28, 2026

Uh oh!

abstractdog commented May 2, 2026

Uh oh!

Aggarwal-Raghav commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Aggarwal-RaghavApr 15, 2026•
edited
Loading