Uh oh!
There was an error while loading. Please reload this page.
TEZ-4677: Upgrades Tez to compile and run with JDK 25 - #482
Conversation
tez-yetus
commented
Apr 15, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
maheshrajus
commented
Jun 25, 2026
It looks like the Jenkinsfile and Dockerfile have changed and been optimized in the latest commits. I need to rebase with the latest changes and check on this task. @Aggarwal-Raghav, if we want to test Tez with JDK 25, which fields in the latest Jenkinsfile and Dockerfile do we need to modify? As far as I can see in the latest changes, there are no fields related to the JDK version. |
@maheshrajus , please check this.
|
Uh oh!
There was an error while loading. Please reload this page.
tez-yetus
commented
Jun 26, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
Jun 26, 2026
(!) A patch to the testing environment has been detected. |
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
Jun 29, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
Jun 29, 2026
(!) A patch to the testing environment has been detected. |
Aggarwal-Raghav
commented
Jun 29, 2026
@maheshrajus , now the spotbugs have failed because its incompatible with jdk25. I'll investigate it in some time to see which is better approach (maven-shading or apache pom version) from my perspective and share my findings as both have some tradeoffs in terms of error |
This much of the patch should be enough. It is passing in local. Regarding Lines 49 to 53 in 17d1549 jdk25.patch |
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
Jun 29, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
Jun 29, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
Jun 29, 2026
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Aggarwal-Raghav
commented
Jun 29, 2026
LGTM +1 for pom, Dockerfile changes. JDK25 changes look good. For checkstyle plese consult with a committer/PMC whether to do in this PR or separate? |
maheshrajus
commented
Jun 29, 2026
@Aggarwal-Raghav All checkstyle issues related to jdk 25 so better to include in this PR itself. @abstractdog Could you please review the PR at your convenience? |
tez-yetus
commented
Jul 2, 2026
(!) A patch to the testing environment has been detected. |
maheshrajus
commented
Jul 2, 2026
@abstractdog spotbugs checked internally and they are running fine. Could you please review the PR at your convenience? |
tez-yetus
commented
Jul 2, 2026
💔 -1 overall
This message was automatically generated. |
maheshrajus
commented
Jul 21, 2026
@abstractdog@ayushtkn |
abstractdog
commented
Jul 21, 2026
is this expected in spotbugs? as far as I know, if you change the Dockerfile, it's picked up, so the new spotbugs is supposed to be used |
maheshrajus
commented
Jul 21, 2026
@abstractdog Yeah, it should pick |
abstractdog
commented
Jul 21, 2026
thanks @maheshrajus I believe the Java 21-related GitHub workflows should be removed once we assume JDK 25 minimum support |
tez-yetus
commented
Jul 22, 2026
(!) A patch to the testing environment has been detected. |
maheshrajus
commented
Jul 22, 2026
@abstractdog i just kept jdk 25 in github workflows. |
tez-yetus
commented
Jul 22, 2026
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.