Skip to content

TEZ-4712: Class-level SpotBugs exclusions for generated Protobuf classes - #489

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4712
May 1, 2026
Merged

TEZ-4712: Class-level SpotBugs exclusions for generated Protobuf classes#489
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4712

Conversation

@Aggarwal-Raghav

@Aggarwal-RaghavAggarwal-Raghav commented Apr 21, 2026

Copy link
Copy Markdown
Contributor
  1. Consolidate specific SpotBugs exclusions into class-level regex matches in findbugs-exclude.xml files.
  2. Generated code should not be manually modified to fix SpotBugs warnings.
  3. This change removes redundant rules targeting individual fields (e.g., PARSER, unknownFields) and methods (e.g., maybeForceBuilderInitialization).

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Once this is merge, will add the rule as part of TEZ-4708 to

<Match>
<Class name="~org\.apache\.tez\.runtime\.internals\.protocolPB\.TezTaskUmbilicalProtocolProtos.*" />
</Match>

which is causing lot of spotbugs verbose alarms.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec13m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚codespell0m 8sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
_ Other Tests _
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
16m 9s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/1/artifact/out/Dockerfile
GITHUB PR#489
Optional Testsdupname asflicense codespell detsecrets xmllint
unameLinux 43927600ef72 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-489/src/.yetus/personality.sh
git revisionmaster / 39f2e4c
Max. process+thread count52 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/1/console
versionsgit=2.43.0 maven=3.9.14 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker9m 40sDocker failed to build run-specific yetus/tez:tp-20126}.
SubsystemReport/Notes
GITHUB PR#489
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/2/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec6m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚codespell0m 7sNo new issues.
+1 💚blanks0m 0sThe patch has no blanks issues.
_ Other Tests _
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
9m 4s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/3/artifact/out/Dockerfile
GITHUB PR#489
Optional Testsdupname asflicense codespell detsecrets xmllint
unameLinux e18429ac581d 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-489/src/.yetus/personality.sh
git revisionmaster / 5f1d624
Max. process+thread count50 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/3/console
versionsgit=2.43.0 maven=3.9.14 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@abstractdog , please check the CI outcome for #493https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-493/1/Yetus_20Report/
for generated proto code the spotbugs is giving -1 which is wrong IMO. This PR will address it, Let me know what's your stance on this

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@abstractdog
abstractdog self-requested a review May 1, 2026 05:43
@abstractdog

Copy link
Copy Markdown
Contributor

+1
This is a very good improvement, not only prevents Findbugs alerts that we cannot help with, but also simplifies our exclude files, thanks @Aggarwal-Raghav !

@abstractdog
abstractdog merged commit 4ffd40f into apache:masterMay 1, 2026
4 checks passed
@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4712 branch May 1, 2026 05:51
Aggarwal-Raghav added a commit to Aggarwal-Raghav/tez that referenced this pull request May 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog