Skip to content

TEZ-4728: Replace deprecated use of Guava Charsets.UTF_8 with StandardCharsets.UTF_8 - #511

Merged
abstractdog merged 2 commits into
apache:masterfrom
Aggarwal-Raghav:TEZ-4728
Jun 18, 2026
Merged

TEZ-4728: Replace deprecated use of Guava Charsets.UTF_8 with StandardCharsets.UTF_8#511
abstractdog merged 2 commits into
apache:masterfrom
Aggarwal-Raghav:TEZ-4728

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall4m 49smaster passed
+1 💚compile3m 58smaster passed
+1 💚checkstyle2m 19smaster passed
+1 💚javadoc2m 33smaster passed
+0 🆗spotbugs1m 25stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 53stez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗spotbugs1m 12stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs0m 44stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚codespell1m 45sNo new issues.
+1 💚compile3m 56sthe patch passed
+1 💚javac3m 56sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 28s/results-checkstyle-tez-api.txttez-api: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 32s/results-checkstyle-tez-runtime-library.txttez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
-0 ⚠️checkstyle0m 24s/results-checkstyle-tez-ext-service-tests.txttez-ext-service-tests: The patch generated 1 new + 42 unchanged - 1 fixed = 43 total (was 43)
-0 ⚠️checkstyle0m 25s/results-checkstyle-tez-plugins_tez-aux-services.txttez-plugins/tez-aux-services: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
+1 💚javadoc2m 32sthe patch passed
+1 💚spotbugs6m 4sthe patch passed
_ Other Tests _
-1 ❌unit78m 24s/patch-unit-root.txtroot in the patch passed.
+1 💚asflicense2m 2sThe patch does not generate ASF License warnings.
124m 1s
ReasonTests
Failed junit teststez.dag.api.client.TestDAGClientServer
tez.dag.app.TestMockDAGAppMaster
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
unameLinux 32ee5d7c8e0f 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 5766cda
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/testReport/
Max. process+thread count1448 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/1/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall2m 52smaster passed
+1 💚compile2m 36smaster passed
+1 💚checkstyle1m 38smaster passed
+1 💚javadoc1m 51smaster passed
+0 🆗spotbugs0m 53stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 33stez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 46stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs0m 31stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall2m 18sthe patch passed
+1 💚codespell0m 48sNo new issues.
+1 💚compile2m 34sthe patch passed
+1 💚javac2m 34sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 19s/results-checkstyle-tez-api.txttez-api: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 22s/results-checkstyle-tez-runtime-library.txttez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
-0 ⚠️checkstyle0m 17s/results-checkstyle-tez-ext-service-tests.txttez-ext-service-tests: The patch generated 1 new + 42 unchanged - 1 fixed = 43 total (was 43)
-0 ⚠️checkstyle0m 17s/results-checkstyle-tez-plugins_tez-aux-services.txttez-plugins/tez-aux-services: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
+1 💚javadoc1m 50sthe patch passed
+1 💚spotbugs3m 49sthe patch passed
_ Other Tests _
+1 💚unit60m 59sroot in the patch passed.
+1 💚asflicense1m 39sThe patch does not generate ASF License warnings.
92m 50s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
unameLinux 51cd086d9c89 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 5766cda
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/testReport/
Max. process+thread count1372 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/2/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

the patch introduced some checkstyle warnings, please fix them, otherwise, looks good to me overall 🚀

@abstractdog
abstractdog self-requested a review June 18, 2026 06:13

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile2m 36smaster passed
+1 💚checkstyle1m 36smaster passed
+1 💚javadoc1m 50smaster passed
+0 🆗spotbugs0m 51stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 34stez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 47stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall2m 11sthe patch passed
+1 💚codespell0m 48sNo new issues.
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 19sThe patch passed checkstyle in tez-api
+1 💚checkstyle0m 18sThe patch passed checkstyle in tez-runtime-internals
+1 💚checkstyle0m 21sThe patch passed checkstyle in tez-runtime-library
+1 💚checkstyle0m 14stez-ext-service-tests: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43)
+1 💚checkstyle0m 18stez-plugins/tez-aux-services: The patch generated 0 new + 52 unchanged - 1 fixed = 52 total (was 53)
+1 💚javadoc1m 40sthe patch passed
+1 💚spotbugs3m 57sthe patch passed
_ Other Tests _
+1 💚unit61m 11sroot in the patch passed.
+1 💚asflicense1m 40sThe patch does not generate ASF License warnings.
90m 28s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
unameLinux b58a0a57af4a 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 5766cda
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/testReport/
Max. process+thread count1361 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-ext-service-tests tez-plugins/tez-aux-services U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-511/3/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajus

Copy link
Copy Markdown
Contributor

LGTM

@abstractdog
abstractdog merged commit 72a42de into apache:masterJun 18, 2026
4 checks passed
@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4728 branch June 18, 2026 14:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Aggarwal-Raghav@tez-yetus@abstractdog@maheshrajus