Skip to content

[WIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome - #514

Open
maheshrajus wants to merge 6 commits into
apache:masterfrom
maheshrajus:TEZ-4476
Open

[WIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome#514
maheshrajus wants to merge 6 commits into
apache:masterfrom
maheshrajus:TEZ-4476

Conversation

@maheshrajus

@maheshrajusmaheshrajus commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome.
PhantomJS is no longer maintained and has known incompatibilities with
modern OpenSSL (3+). So better to Replace it with Headless Chrome.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec4m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall4m 47smaster passed
+1 💚compile3m 59smaster passed
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 51sthe patch passed
-1 ❌codespell1m 36s/results-codespell.txtThe patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
-1 ❌unit77m 0s/patch-unit-root.txtroot in the patch failed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
102m 9s
ReasonTests
Failed junit teststez.history.TestHistoryParser
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc codespell detsecrets xmllint jsonlint
unameLinux cbe42f53ed77 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 17d1549
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/testReport/
Max. process+thread count1437 (vs. ulimit of 5500)
modulesC: tez-ui U: tez-ui
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/console
versionsgit=2.43.0 maven=3.9.15 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall4m 33smaster passed
+1 💚compile3m 58smaster passed
+1 💚javadoc1m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 40sthe patch passed
+1 💚codespell1m 35sNo new issues.
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc1m 49sthe patch passed
_ Other Tests _
-1 ❌unit73m 39s/patch-unit-root.txtroot in the patch failed.
-1 ❌asflicense1m 30s/results-asflicense.txtThe patch generated 1 ASF License warnings.
99m 4s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets javac javadoc xmllint jsonlint
unameLinux a3d388f95334 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 17d1549
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/testReport/
Max. process+thread count1524 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/console
versionsgit=2.43.0 maven=3.9.15 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 36smaster passed
+1 💚compile3m 56smaster passed
+1 💚javadoc1m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
+1 💚mvninstall3m 51sthe patch passed
+1 💚codespell1m 36sNo new issues.
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚javadoc1m 52sthe patch passed
_ Other Tests _
-1 ❌unit72m 49s/patch-unit-root.txtroot in the patch failed.
+1 💚asflicense1m 30sThe patch does not generate ASF License warnings.
98m 30s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets javac javadoc xmllint jsonlint
unameLinux e07e9b03e809 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 17d1549
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/testReport/
Max. process+thread count1542 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/console
versionsgit=2.43.0 maven=3.9.15 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 35smaster passed
+1 💚compile4m 0smaster passed
+1 💚javadoc1m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚codespell1m 35sNo new issues.
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 2sNo new issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
+1 💚unit76m 26sroot in the patch passed.
+1 💚asflicense1m 30sThe patch does not generate ASF License warnings.
103m 30s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint jsonlint
unameLinux 016c58a2ad3d 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 17d1549
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/testReport/
Max. process+thread count2069 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

@abstractdog@ayushtkn
Could you please review the PR at your convenience?
Thank you !

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for this patch @maheshrajus, a few notes:

  1. after removing phantomjs, we can try to build tez-ui also on arm64:

    && '-pl !tez-ui' || '' }}

  2. checked out pr, ran mvn clean install in tez-ui and I saw a browser window running the tests:

Screenshot 2026-06-30 at 14 40 40 while it was awesome to see, I'm expecting a headless browser to not display at all, does it make sense?
  1. after install, I got this diff:
-"moment@>= 2.29.4":
- version "2.29.4"
- resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
+"moment@>= 2.6.0":
+ version "2.30.1"
+ resolved "https://registry.yarnpkg.com/moment/-/moment-2.30.1.tgz#f8c91c07b7a786e30c59926df530b4eac96974ae"

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Thank you for the review.
Let me check and address the review comments.

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

2. checked out pr, ran mvn clean install in tez-ui and I saw a browser window running the tests:

@abstractdog Initially the changes related to headless present in my first commit. After that while fixing ui-tests it got overwritten. Let me fix and run locally and verify it. thanks !

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/5/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/6/console in case of problems.

@maheshrajusmaheshrajus changed the title TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome[wIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless ChromeJul 1, 2026
@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/7/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/8/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 37smaster passed
+1 💚compile4m 1smaster passed
+1 💚javadoc1m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚codespell1m 46sNo new issues.
+1 💚jshint109m 35sNo new issues.
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 2sNo new issues.
-1 ❌markdownlint0m 3s/results-markdownlint.txtThe patch generated 11 new + 51 unchanged - 0 fixed = 62 total (was 51)
+1 💚shellcheck0m 0sNo new issues.
+1 💚javadoc1m 52sthe patch passed
_ Other Tests _
-1 ❌unit71m 41s/patch-unit-root.txtroot in the patch failed.
+1 💚asflicense1m 29sThe patch does not generate ASF License warnings.
207m 18s
ReasonTests
Failed junit teststez.history.TestHistoryParser
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/8/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint markdownlint jsonlint jshint
unameLinux 82067fc2e13b 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 8fde353
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/8/testReport/
Max. process+thread count1479 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/8/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 jshint=2.13.6 markdownlint=0.46.0 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/9/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗xmllint0m 1sxmllint was not available.
+0 🆗jsonlint0m 1sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall4m 39smaster passed
+1 💚compile3m 57smaster passed
+1 💚javadoc1m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 46sthe patch passed
+1 💚codespell1m 35sNo new issues.
+1 💚jshint109m 16sNo new issues.
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 1sNo new issues.
+1 💚markdownlint0m 3sNo new issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
+1 💚unit75m 54sroot in the patch passed.
+1 💚asflicense1m 27sThe patch does not generate ASF License warnings.
211m 2s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/9/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint markdownlint jsonlint jshint
unameLinux 23ec5b3d53ba 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 8fde353
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/9/testReport/
Max. process+thread count1486 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/9/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 jshint=2.13.6 markdownlint=0.46.0 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajusmaheshrajus changed the title [wIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless ChromeTEZ-4476: Move tez-ui testing from PhantomJS to Headless ChromeJul 2, 2026
@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/10/console in case of problems.

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor
  1. after removing phantomjs, we can try to build tez-ui also on arm64:

@abstractdog Can we handle this in separate JIRA ?

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

@abstractdog I fixed your review comments and verified locally + in yetus CI env.
Could you please review the PR at your convenience?
Thank you !

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec4m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗shelldocs0m 1sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 38sMaven dependency ordering for branch
+1 💚mvninstall4m 31smaster passed
+1 💚compile4m 2smaster passed
+1 💚javadoc1m 54smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 44sthe patch passed
+1 💚codespell1m 35sNo new issues.
+1 💚jshint109m 6sNo new issues.
+1 💚compile4m 4sthe patch passed
+1 💚javac4m 4sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 0sNo new issues.
+1 💚markdownlint0m 3sNo new issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
+1 💚unit77m 5sroot in the patch passed.
+1 💚asflicense1m 29sThe patch does not generate ASF License warnings.
216m 31s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/10/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint markdownlint jsonlint jshint
unameLinux 70d447d0c557 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / d53e67d
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/10/testReport/
Max. process+thread count1467 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/10/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 jshint=2.13.6 markdownlint=0.46.0 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

@abstractdog I fixed your review comments and verified locally + in yetus CI env. Could you please review the PR at your convenience? Thank you !

looks good so far, I have only one concern: on a vanilla ubuntu server, when chromium wasn't installed, the build simply failed by:

Building..Built project successfully. Stored in "/home/abstractdog/apache/tez/tez-ui/src/main/webapp/tmp/class-tests_dist-NhEe6O0O.tmp".
not ok 1 Chrome - Browser "scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type <url>" exited unexpectedly.

if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a mvn clean install command, which doesn't sound good to me
could the build process take care of the same automatically?

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a mvn clean install command, which doesn't sound good to me
could the build process take care of the same automatically?

@abstractdog Thank you for the review. I have not taken care of chromium, Let me check and fix it.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/11/console in case of problems.

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

@abstractdog I have addressed your review comments and tested the changes in the environments listed below. Everything is working as expected.
Please let me know if I missed anything or if I should verify this in any other environment. Thanks !

macOS with & without system chrome, Ubuntu 22.04 – no system Chrome
Ubuntu 22.04 – system Chrome installed
Debian 12 – no system Chrome
Amazon Linux 2023 – no system Chrome

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec5m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 30smaster passed
+1 💚compile4m 2smaster passed
+1 💚javadoc1m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 51sthe patch passed
+1 💚codespell1m 38sNo new issues.
+1 💚jshint109m 16sNo new issues.
+1 💚compile4m 4sthe patch passed
+1 💚javac4m 4sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 2sNo new issues.
+1 💚markdownlint0m 3sNo new issues.
-1 ❌shellcheck0m 1s/results-shellcheck.txtThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
+1 💚unit77m 33sroot in the patch passed.
+1 💚asflicense1m 29sThe patch does not generate ASF License warnings.
217m 40s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/11/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint markdownlint jsonlint jshint
unameLinux d48569a14c5b 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 4bccf3a
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/11/testReport/
Max. process+thread count1408 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/11/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 jshint=2.13.6 markdownlint=0.46.0 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/12/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗shelldocs0m 1sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+0 🆗jsonlint0m 0sjsonlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall4m 43smaster passed
+1 💚compile4m 4smaster passed
+1 💚javadoc1m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 55sthe patch passed
+1 💚codespell1m 37sNo new issues.
+1 💚jshint109m 43sNo new issues.
+1 💚compile4m 5sthe patch passed
+1 💚javac4m 5sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚hadolint0m 0sNo new issues.
+1 💚markdownlint0m 3sNo new issues.
+1 💚shellcheck0m 1sNo new issues.
+1 💚javadoc1m 55sthe patch passed
_ Other Tests _
+1 💚unit77m 24sroot in the patch passed.
+1 💚asflicense1m 30sThe patch does not generate ASF License warnings.
213m 29s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/12/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint markdownlint jsonlint jshint
unameLinux 2017c56f3296 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 4bccf3a
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/12/testReport/
Max. process+thread count1528 (vs. ulimit of 5500)
modulesC: tez-ui . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/12/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 jshint=2.13.6 markdownlint=0.46.0 shellcheck=0.11.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

@abstractdog
Could you please review the PR at your convenience?
Thank you !

@abstractdog

abstractdog commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@abstractdog Could you please review the PR at your convenience? Thank you !

thanks @maheshrajus , tried it on a vanilla ubuntu, and doesn't seem to work as I expect, let me share what I can see and maybe you can tell if I miss something:

  1. run mvn clean install in tez-ui, the doc says "yarn install" (run automatically by Maven) takes care of that

  2. I get an error like:

Building...Built project successfully. Stored in "/home/abstractdog/apache/tez/tez-ui/src/main/webapp/tmp/class-tests_dist-oQZlTw0S.tmp".
not ok 1 Chrome - Browser "scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type <url>" exited unexpectedly.
1..1
# tests 1
# pass 0
# fail 1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
  1. running it manually: empty response, not even an echo I would expect
abstractdog@ubuntu-8gb-hel1-3:~/apache/tez/tez-ui$ ./src/main/webapp/scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors "fake"
abstractdog@ubuntu-8gb-hel1-3:~/apache/tez/tez-ui$ echo $?
127

so I'm not sure anymore if mvn install automatically takes care of yarn install, or I have to do it, becuase even if I saw the echo message, it would tell "Alternatively, run 'yarn install' inside src/main/webapp to let puppeteer download Chromium automatically.", but doc says "# "yarn install" (run automatically by Maven) will download a bundled # Chromium, so the build works on a vanilla machine with no pre-installed"

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

thanks @maheshrajus , tried it on a vanilla ubuntu, and doesn't seem to work as I expect, let me share what I can see and maybe you can tell if I miss something:

I checked it locally with ubuntu and worked for me. Let check it if i am missing anything over here. need to check if already yarn package installed in this vm or not. Let me check and run in freshly created vanilla ubuntu vm. thanks !

@maheshrajusmaheshrajus changed the title TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome[WIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless ChromeJul 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@maheshrajus@tez-yetus@abstractdog