Skip to content

TEZ-4747: Upgrade mockito to 5.23.0 - #529

Open
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4747
Open

TEZ-4747: Upgrade mockito to 5.23.0#529
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4747

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

No description provided.

verify(client2.sessionAmProxy, times(1)).shutdownSession(any(),
any());
verify(client2.mockYarnClient, times(1)).stop();
verify(client2.mockYarnClient, times(1)).close();

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mockito4 couldn't mock final methods and yarnClient.close() was final so it was checking for stop() in AbstractService.java

 @Override
public final void close() throws IOException {
stop();
}

But in Mockito 5 it can mock final method so it will test for close()

}
verify(activeLogger, times(0)).info(anyString());
verify(aggregateLogger, times(1)).info(anyString(), ArgumentMatchers.<Object[]>any());
verify(aggregateLogger, times(1)).info(anyString(), any(), any(), any(), any(), any());

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec3m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall2m 54smaster passed
+1 💚compile2m 35smaster passed
+1 💚checkstyle1m 24smaster passed
+1 💚javadoc1m 54smaster passed
+0 🆗spotbugs0m 51stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 42stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs3m 52sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 23sthe patch passed
+1 💚codespell0m 49sNo new issues.
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 12sthe patch passed
+1 💚javadoc1m 45sthe patch passed
+1 💚spotbugs5m 50sthe patch passed
_ Other Tests _
-1 ❌unit61m 22s/patch-unit-root.txtroot in the patch passed.
+1 💚asflicense1m 15sThe patch does not generate ASF License warnings.
97m 43s
ReasonTests
Failed junit teststez.dag.history.logging.ats.TestATSHistoryLoggingService
tez.runtime.api.impl.TestProcessorContext
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle
unameLinux bed0c3626bb3 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / d348bf1
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/testReport/
Max. process+thread count1408 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/1/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec10m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 41sMaven dependency ordering for branch
+1 💚mvninstall4m 28smaster passed
+1 💚compile4m 1smaster passed
+1 💚checkstyle2m 56smaster passed
+1 💚javadoc3m 41smaster passed
+0 🆗spotbugs1m 20stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 53stez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗spotbugs1m 10stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs0m 43stez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings.
+0 🆗spotbugs6m 27sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚codespell1m 36sNo new issues.
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle2m 52sthe patch passed
+1 💚javadoc3m 38sthe patch passed
+1 💚spotbugs11m 36sthe patch passed
_ Other Tests _
+1 💚unit77m 33sroot in the patch passed.
+1 💚asflicense2m 39sThe patch does not generate ASF License warnings.
148m 45s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle
unameLinux bcfbae048548 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / d348bf1
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/testReport/
Max. process+thread count2121 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-plugins/tez-yarn-timeline-history . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-529/3/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

CC @abstractdog , requesting review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Aggarwal-Raghav@tez-yetus