Skip to content

TEZ-4267: Remove Superfluous Code from DAGAppMaster - #90

Merged
jteagles merged 3 commits into
apache:masterfrom
belugabehr:TEZ-4267
Jun 30, 2021
Merged

TEZ-4267: Remove Superfluous Code from DAGAppMaster#90
jteagles merged 3 commits into
apache:masterfrom
belugabehr:TEZ-4267

Conversation

@belugabehr

Copy link
Copy Markdown
Contributor

No description provided.

}
}

private static void validateInputParam(String value, String param)

@belugabehrbelugabehrJan 24, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in one place. Limited value,

/**
* set of already executed dag names.
*/
Set<String> dagNames = new HashSet<String>();

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No references to this variable anywhere

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall12m 18smaster passed
+1 💚compile0m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 33smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle1m 11smaster passed
+1 💚javadoc0m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 32smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs1m 41sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 40smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 26sthe patch passed
+1 💚compile0m 30sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 30sthe patch passed
+1 💚compile0m 24sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac0m 24sthe patch passed
+1 💚checkstyle0m 18stez-dag: The patch generated 0 new + 53 unchanged - 1 fixed = 53 total (was 54)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 22sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 21sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚findbugs1m 8sthe patch passed
_ Other Tests _
+1 💚unit4m 18stez-dag in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
27m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/artifact/out/Dockerfile
GITHUB PR#90
JIRA IssueTEZ-4267
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 5a1ec7ed26ad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 4684d06
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/testReport/
Max. process+thread count188 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteagles
jteagles merged commit 47a59ab into apache:masterJun 30, 2021
asfgit pushed a commit that referenced this pull request Jun 30, 2021
* TEZ-4267: Remove Superfluous Code from DAGAppMaster
* Remove superfluous variable
* Remove superfluous comment
Co-authored-by: David Mollitor <david.mollitor@cloudera.com>
(cherry picked from commit 47a59ab)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@belugabehr@hadoop-yetus@jteagles