☂ cmake: audit tasks

[cmcfarlen]

• Fixup places that use manual target_include_directories vs target deps
• Verify all headers get installed as intended
• Compare feature flags ENABLE_*
• Compare checks HAVE_*

[ywkaras]

My development environment is in a x86_64, RHEL8(-ish, Yahoo kernel mods) container in the Yahoo internal cloud. The autotools ./configure detects it as supporting 128 bit CAS. cmake detects in as not supporiting 128 bit CAS.

O$ uname -mpi
x86_64 x86_64 x86_64

update: #10680 fixes this issue. In any case, I'm not sure, for an x86_64 architecture if it's really better to use 128 bit CAS (instead of putting the pointer version in the unused 15 pointer bits).

[ywkaras]

-Djemalloc_ROOT=xxx doesn't seem to be working.

update: It works when combined with -DENABLE_JEMALLOC=ON .

[ywkaras]

Some Catch unit tests are missing in the CMake build:

wkaras ~/REPOS/TS
O$ cat ~/find_catch
CML=$( find . -name CMakeLists.txt )
LAST='NONE'
grep -l -F CATCH_CONFIG_MAIN $( find . -name *.cc -o -name *.cpp ) | while read P
do
F=$( basename $P )
if [[ $F != $LAST ]] ; then
COUNT=$( grep -l -F $F $CML | wc -l )
fi
if (( COUNT == 0 )) ; then
echo "$F missing"
else
let COUNT=COUNT-1
fi
LAST=$F
done
wkaras ~/REPOS/TS
O$ . ~/find_catch
authproxy_test.cc missing
uri_signing_test.cc missing
test_HostFile.cc missing
test_MTHashTable.cc missing
event_processor_main.cc missing
test_NextHopConsistentHash.cc missing
test_NextHopRoundRobin.cc missing
test_NextHopStrategyFactory.cc missing
test_PluginDso.cc missing
test_PluginFactory.cc missing
test_RemapPlugin.cc missing
benchmark_LogObject.cc missing
test_RolledLogDeleter.cc missing
wkaras ~/REPOS/TS
O$

I can't think of a quick way to check if any non-catch unit tests are missing.

[ywkaras]

It looks like there may be over 200 c/cpp/cc file that appear in a Makefile.am or Makefile.inc file, but not in a CMakeLists.txt file. I will work on addressing this.

[cmcfarlen]

One way I have found to find the differences is to enable cmake's CMAKE_EXPORT_COMPILE_COMMANDS option and then compare that to the filesystem. Cmake will output a compile_commands.json file that lists every file that will be compiled as part of the build.

jq -r 'map(.file)[]' compile_commands.json | sort | uniq > compiled.txt

find "$(pwd)" -type f -name "*.cc" -or -name "*.cpp" | sort > files.txt

Then you can diff these files. For this to work, you have to have a cmake that builds with every available option (autest, quic, experimental plugins, benchmarks, etc). There are known missing items like the plugins listed in #10242 and the tests in swoc in yaml-cpp that we don't build. There are also some files (i.e. the fastcgi plugin) that autotools also does not build.

Thanks for helping to audit the cmake build @ywkaras!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

[bryancall]

This was an audit of differences between the autotools and CMake builds during the migration. It has been overtaken by events. The 128-bit compare-and-swap (CAS) detection mismatch was fixed in #10680, first released in 10.0.0. Autotools was then removed entirely in #10794, also first released in 10.0.0, so the central item here (files present in Makefile.am or Makefile.inc but not in any CMakeLists.txt) no longer applies, there is no longer a second build system to compare against and current master has no Makefile.am, Makefile.inc, or configure.ac. The jemalloc_ROOT item was resolved in this thread (it works when combined with -DENABLE_JEMALLOC=ON), and the specific missing Catch unit test files listed here no longer exist under those names after the source tree reorganization. Closing as obsolete. If any specific unit test is still not wired into the CMake build today, please open a fresh, targeted issue naming the current file.