traffic_ctl config status reports unnecessarily that a restart is required after touching ssl_multicert

[jvgutierrez]

traffic_ctl config status reports that a restart is required after touching ssl_multicert.config:

vgutierrez@cp2003:~$ sudo -i traffic_ctl config status
Apache Traffic Server - traffic_server - 8.0.3 - (build # 032510 on Mar 25 2019 at 10:48:39)
Started at Mon May  6 16:59:39 2019
Last reconfiguration at Mon May  6 16:59:38 2019
Configuration is current
vgutierrez@cp2003:~$ sudo -i touch /etc/trafficserver/ssl_multicert.config
vgutierrez@cp2003:~$ sudo -i traffic_ctl config status
Apache Traffic Server - traffic_server - 8.0.3 - (build # 032510 on Mar 25 2019 at 10:48:39)
Started at Mon May  6 16:59:39 2019
Last reconfiguration at Mon May  6 16:59:38 2019
Reconfiguration required
vgutierrez@cp2003:~$ sudo -i traffic_ctl config reload
vgutierrez@cp2003:~$ sudo -i traffic_ctl config status
Apache Traffic Server - traffic_server - 8.0.3 - (build # 032510 on Mar 25 2019 at 10:48:39)
Started at Mon May  6 16:59:39 2019
Last reconfiguration at Mon May  6 17:00:04 2019
Configuration is current
traffic_server requires restarting

Take into account that ssl_multicert.config documentation states:

Changes to ssl_multicert.config can be applied to a running Traffic Server using traffic_ctl config reload

[PSUdaemon]

I looked into this a bit and it seems that we conflate a config value changing with the file that the config value points to. So it ends up showing restart needed because if you change the filename of ssl_multicert.config to something else, it does require a restart, however the file manager code simply says that the config file changed but it doesn't get interpreted correctly. This probably isn't a simple fix.

[brbzull0]

does not seems to be an issue anymore, at least in 10.

$ traffic_ctl config status
Version: Apache Traffic Server - traffic_server - 10.1.0 - (build # 0 on Sep 23 2024 at 09:08:15)
Started at: Mon 04 Nov 2024 14:56:36
Reconfigured at: Mon 04 Nov 2024 14:56:36
Reconfigure required: no
Restart required: no
$ touch /opt/ats/etc/trafficserver/ssl_multicert.config
$ traffic_ctl config status
Version: Apache Traffic Server - traffic_server - 10.1.0 - (build # 0 on Sep 23 2024 at 09:08:15)
Started at: Mon 04 Nov 2024 14:56:36
Reconfigured at: Mon 04 Nov 2024 14:56:36
Reconfigure required: no
Restart required: no

[bryancall]

I cannot reproduce this on current releases. The maintainer above traced the bug to the old traffic_manager file manager, which conflated a config value change with the file that value points to. That entire traffic_manager subsystem was removed in #8633, which first shipped in Apache Traffic Server 10.0.0. In current source, traffic_ctl config status reads the proxy.process.proxy.reconfigure_required and proxy.process.proxy.restart_required metrics, which are created at startup and are no longer set spuriously when a configuration file is touched. A committer also confirmed clean output (Restart required: no) on 10.1.0 after touching ssl_multicert.config. Closing as resolved by the 10.x management rework. Please reopen if you still see this on a 10.x or newer release.