Skip to content

Add better access control to XDebug plugin #6334

Description

@zwoop

The existing "ACL" mechanism is weak (obfuscating the header). Seeing that we've added a lot more information, some of which is sensitive, some which is computationally expensive, I feel strongly that we should add better ACL mechanisms ASAP. Being late in the game, I'm ok with postponing this until 9.1.x.

The suggestion would include

--allow=x-cache,x-cache-key

and

--deny=purge

And possibly,

--ip_allow=10.0.0.0-10.255.255.255 # or something like 10.0.0.0/8

We can discuss the default "allowed" fields here as well, but I think that x-cache alone is the one useful one. Also, bear in mind that a lot of this might be superseded with a new header in the future, Cache-Status:

https://tools.ietf.org/html/draft-ietf-httpbis-cache-header-02

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions