Skip to content

Rename IpEndpoint::port to network_order_port #8407

Description

@bneradt

This issue comes out of the patch to fix a byte ordering bug:

It's easy for a developer to use IpEndpoint::port without thinking explicitly about whether they need network byte order or host byte order versions of the port. In the PR review meeting for #8406, it was suggested that we rename IpEndpoint::port to IpEndpoint:: network_order_port so it would make explicit that byte ordering must be considered.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions